Deprecate decoding msg! events to improve errorOnDecodeFailure event parsing. #2340
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anchor decodes events by checking if the transaction log line starts with "Program log:" (msg! system call) or "Program data" (sol_log_data system call).
This means that it attempts to decode all program logs.
After anchor 0.23.0 (2022-03-20) anchor switched to emitting events using the sol_log_data system_call (#1608).
This created a clear distinction between anchor events logs and logs for other purposes.
The problem being that when you pass errorOnDecodeFailure=true to parseLogs it will fail on all non anchor event program logs.
I propose deprecating attempting to parse msg! logs so anchor only attempts to parse genuine anchor event candidates.