Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming of POSTed JSON parameters #1

Open
kdavis-coqui opened this issue May 29, 2021 · 2 comments
Open

Renaming of POSTed JSON parameters #1

kdavis-coqui opened this issue May 29, 2021 · 2 comments

Comments

@kdavis-coqui
Copy link
Member

Could we rename the POSTed parameters from

{
        "name": "test_model",
        "language": "english",
        "version": "0.0.1",
        "creator": "reuben",
        "acoustic": "https://github.com/coqui-ai/STT-models/releases/download/english/coqui/v0.9.3/model.pbmm",
        "scorer": "https://github.com/coqui-ai/STT/releases/download/v0.9.3/coqui-stt-0.9.3-models.scorer"
}

to

{
        "name": "test_model",
        "language": "english",
        "modelVersion": "0.0.1",
        "modelCreator": "reuben",
        "acousticModelURL": "https://github.com/coqui-ai/STT-models/releases/download/english/coqui/v0.9.3/model.pbmm",
        "scorerURL": "https://github.com/coqui-ai/STT/releases/download/v0.9.3/coqui-stt-0.9.3-models.scorer"
}

Just to be more specific, as there are model versions and code version, code creators and model creators, and "acoustic" isn't the model but its URL similarly for "scorer".

Also as a suggestion we should also add the code version too, e.g. something like

{
        ...
        "codeVersion": "0.9.3",
        ...
}

to help with future proofing things.

@reuben
Copy link
Contributor

reuben commented May 29, 2021

Yep, of course :)

@reuben
Copy link
Contributor

reuben commented Jun 3, 2021

Actually as we'll be switching to the official model card JSON format eventually we should stick to the official schema.

reuben pushed a commit that referenced this issue Jun 7, 2021
Update message about closed-vocab models
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants