Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment in genarg.mli about useful registrations #19685

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

SkySkimmer
Copy link
Contributor

(+ fix small incompleteness in the ARGUMENT EXTEND syntax in dev/doc/parsing.md)

@SkySkimmer SkySkimmer requested review from a team as code owners October 14, 2024 11:13
@coqbot-app coqbot-app bot added the needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. label Oct 14, 2024
@SkySkimmer
Copy link
Contributor Author

AFAICT after #19646 all genarg uses fit in one of the mentioned cases.

(+ fix small incompleteness in the ARGUMENT EXTEND syntax in dev/doc/parsing.md)
@SkySkimmer SkySkimmer added kind: documentation Additions or improvement to documentation. and removed needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. labels Oct 14, 2024
@SkySkimmer SkySkimmer added this to the 9.0+rc1 milestone Oct 14, 2024
@ppedrot ppedrot self-assigned this Oct 14, 2024
@ppedrot
Copy link
Member

ppedrot commented Oct 14, 2024

I'm a bit wary that these comments will quickly become obsolete whenever we clean up some of the APIs, but it's also fine as-is.

@ppedrot
Copy link
Member

ppedrot commented Oct 15, 2024

@coqbot merge now

@coqbot-app coqbot-app bot merged commit a79fb09 into coq:master Oct 15, 2024
6 checks passed
@SkySkimmer SkySkimmer deleted the comment-genarg branch October 15, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: documentation Additions or improvement to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants