-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Nix CI setup. #29
Conversation
So this works quite well. I'm leaving the PR open for the maintainers to decide whether it's interesting having or not. A feature is that |
This looks like a really good idea to me, and I think it should be merged. However, I will first take the liberty to make sure we test both the Dune builds and the coq_makefile builds in CI, by making the opam packages use Dune (this is arguably one of the big benefits of this setup). Then, I will leave the ultimate merging decision to @chdoc. |
I am happy to use this project also as a test case for the nix-based CI. I guess the project is lightweight enough that we can run various CI configurations. I am a bit confused that the |
@chdoc if we set |
I don't have strong feelings about this. I think it's good if |
Well, everybody will have Dune installed and available, but this is very far from that Dune is fully replacing coq_makefile. My bet is that (1) Dune long term support for Coq is at least a year away and (2) we are several years away from most people using Dune to build their Coq projects. Hence, I still think supporting both build approaches is the correct choice. |
Sure, I wasn't suggesting that |
I'm opening this PR to test the new Nix CI setup I have been working on following discussions with @palmskog on a project with extra Coq dependencies.