refactor: drop pyyaml-include dependency and reimplement relevant features
#1541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sisp
force-pushed
the
refactor/drop-pyyaml-include
branch
from
423f307 to
6c3553c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1541 +/- ##
==========================================
- Coverage 97.48% 97.36% -0.13%
==========================================
Files 48 48
Lines 4568 4585 +17
==========================================
+ Hits 4453 4464 +11
- Misses 115 121 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sisp
force-pushed
the
refactor/drop-pyyaml-include
branch
from
6c3553c to
2eaaad2
Compare
|
Let me add some tests to get rid of the two ❌, they don't look good. 😆 |
sisp
force-pushed
the
refactor/drop-pyyaml-include
branch
2 times, most recently
from
cd2d23d to
801d547
Compare
pawamoy
approved these changes
Feb 28, 2024
sisp
force-pushed
the
refactor/drop-pyyaml-include
branch
from
801d547 to
ba684d0
Compare
|
@pawamoy Sorry about the frequent force-pushes. I couldn't decide on test case names ... 😆 |
sisp
force-pushed
the
refactor/drop-pyyaml-include
branch
from
ba684d0 to
15b4fcf
Compare
|
Testing pays off ... ☝️ 😆 |
|
I think we're good now. Merging ... 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've dropped the
pyyaml-includedependency and reimplemented the features we use in Copier, which are just a subset of whatpyyaml-includeoffers.Resolves #1398.