Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lets put jquery in the bin #20

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Lets put jquery in the bin #20

wants to merge 11 commits into from

Conversation

omidantilong
Copy link
Collaborator

Changes:

  • Completely removes jquery from the frontend
  • Does NOT remove the jquery script tag yet - we should do this separately (it appears to still be used by the mailchimp signup widget)
  • All the ui interaction has been rewritten in vanilla js
  • Fixes the collapsible menu flicker when navigating between pages in the same section
  • Makes the search input more predictable
  • Allows closing the menu with a second press of esc, or a single press if the search input does not have focus
  • Removes the need to set is-open classes on everything by utilising the cascade
  • Uses IntersectionObserver for the back-to-top link rather than binding to the scroll event
  • Debounces window resize logic rather than binding to the raw resize event
  • Started inline media queries in their parent class where appropriate

This is by no means a total fixup. We should look to move away from gulp (5s compile times 😱 ) and .cjs files, start using prettier (etc) in our local environments, and so on. It would be cool to rebuild this as a next app using the learnings from the workbench project.

But this hopefully puts us in a better place in the meantime.

@omidantilong omidantilong requested a review from matt-tyas April 27, 2022 14:42
@matt-tyas
Copy link
Collaborator

@omidantilong I missed this. If we can resolve the merge conflict this branch now has I'll take a look and merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants