Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete donation block in about page #575

Merged
merged 4 commits into from
Jan 8, 2021
Merged

delete donation block in about page #575

merged 4 commits into from
Jan 8, 2021

Conversation

markets
Copy link
Collaborator

@markets markets commented Jan 4, 2021 •
edited
Loading

Delete donation link in about page (closes #572)

EXTRA

  • ✂️ useless css class
  • ✂️ useless entries in .gitignore
  • DRY select2 initialization

@markets
Copy link
Collaborator Author

markets commented Jan 4, 2021 •
edited
Loading

@sseerrggii these 3 translation keys should be removed in Localeapp too:

  • pages.about.donate-title
  • pages.about.donate-text
  • pages.about.donate-link

@markets markets changed the title delete donation block in about page (closes #572) delete donation block in about page Jan 5, 2021
@sseerrggii
Copy link
Contributor

sseerrggii commented Jan 5, 2021 •
edited
Loading

Thanks @markets

I will remove the keys in localeapp when the merge has been done #577

@sseerrggii sseerrggii mentioned this pull request Jan 5, 2021
Closed
@markets markets force-pushed the remove_donation_info branch from f7ae23e to 13d0e41 Compare January 5, 2021 15:05
@sseerrggii
Copy link
Contributor

Tested 👍

@sseerrggii sseerrggii merged commit 640cd29 into develop Jan 8, 2021
@sseerrggii sseerrggii mentioned this pull request Jan 8, 2021
Merged
@markets markets deleted the remove_donation_info branch January 10, 2021 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove donation information from about page
2 participants
@markets @sseerrggii