Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump devise from 4.5.0 to 4.7.1 #514

Merged
merged 1 commit into from
Feb 26, 2020
Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 20, 2019

Bumps devise from 4.5.0 to 4.7.1.

Changelog

Sourced from devise's changelog.

4.7.1 - 2019-09-06

  • bug fixes
    • Fix an edge case where records with a blank confirmation_token could be confirmed (by @​tegon)
    • Fix typo inside update_needs_confirmation i18n key (by @​lslm)

4.7.0 - 2019-08-19

  • enhancements

    • Support Rails 6.0
    • Update CI to rails 6.0.0.beta3 (by @​tunnes)
    • refactor method name to be more consistent (by @​saiqulhaq)
    • Fix rails 6.0.rc1 email uniqueness validation deprecation warning (by @​Vasfed)
  • bug fixes

    • Add autocomplete="new-password" to password_confirmation fields (by @​ferrl)
    • Fix rails_51_and_up? method for Rails 6.rc1 (by @​igorkasyanchuk)

4.6.2 - 2019-03-26

4.6.1 - 2019-02-11

  • bug fixes
    • Check if root_path is defined with #respond_to? instead of #present (by @​tegon)

4.6.0 - 2019-02-07

  • enhancements

    • Allow to skip email and password change notifications (by @​iorme1)
    • Include the use of nil for allow_unconfirmed_access_for in the docs (by @​joaumg)
    • Ignore useless files into the .gem file (by @​huacnlee)
    • Explain the code that prevents enumeration attacks inside Devise::Strategies::DatabaseAuthenticatable (by @​tegon)
    • Refactor the devise_error_messages! helper to render a partial (by @​prograhamer)
    • Add an option (Devise.sign_in_after_change_password) to not automatically sign in a user after changing a password (by @​knjko)
  • bug fixes

    • Fix missing comma in Simple Form generator (by @​colinross)
    • Fix error with migration generator in Rails 6 (by @​oystersauce8)
    • Set encrypted_password to nil when password is set to nil (by @​sivagollapalli)
    • Consider whether the request supports flash messages inside Devise::Controllers::Helpers#is_flashing_format? (by @​colinross)
    • Fix typo inside Devise::Generators::ControllersGenerator (by @​kopylovvlad)
    • Sanitize parameters inside Devise::Models::Authenticatable#find_or_initialize_with_errors (by @​rlue)
    • #after_database_authentication callback was not called after authentication on password reset (by @​kanmaniselvan)
    • Fix corner case when #confirmation_period_valid? was called at the same second as confirmation_sent_at was set. Mostly true for date types that only have second precisions. (by @​stanhu)
    • Fix unclosed li tag in error_messages partial (by @​mracos)
    • Fix Routes issue when devise engine is mounted in another engine on Rails versions lower than 5.1 (by @​a-barbieri)
    • Make #increment_failed_attempts concurrency safe (by @​tegon)
... (truncated)
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot dependabot bot force-pushed the dependabot/bundler/devise-4.7.1 branch from 8aa0692 to c4c4396 Compare December 10, 2019 15:40
@sseerrggii
Copy link
Contributor

I'm trying to deploy this branch in staging but i have this error:

$ bundle exec cap staging deploy

INFO rbenv: rbenv_ruby is not set; ruby version will be defined by the remote hosts via rbenv INFO [e37ab1eb] Running /usr/bin/env mkdir -p /tmp/timeoverflow/ as [email protected] DEBUG [e37ab1eb] Command: ( export RBENV_ROOT="$HOME/.rbenv" RBENV_VERSION="" ; /usr/bin/env mkdir -p /tmp/timeoverflow/ ) /var/www/timeoverflow/vendor/bundle/ruby/2.6.0/gems/net-ssh-2.9.2/lib/net/ssh/transport/session.rb:67: warning: Object#timeout is deprecated, use Timeout.timeout instead. /var/www/timeoverflow/vendor/bundle/ruby/2.6.0/gems/net-ssh-2.9.2/lib/net/ssh/transport/session.rb:84: warning: Object#timeout is deprecated, use Timeout.timeout instead. /var/www/timeoverflow/vendor/bundle/ruby/2.6.0/gems/net-ssh-2.9.2/lib/net/ssh/transport/cipher_factory.rb:98: warning: constant OpenSSL::Cipher::Cipher is deprecated #<Thread:0x0000555a7e766b90@/var/www/timeoverflow/vendor/bundle/ruby/2.6.0/gems/sshkit-1.8.1/lib/sshkit/runners/parallel.rb:11 run> terminated with exception (report_on_exception is true): Traceback (most recent call last): 27: from /var/www/timeoverflow/vendor/bundle/ruby/2.6.0/gems/sshkit-1.8.1/lib/sshkit/runners/parallel.rb:13:in block (2 levels) in execute'
26: from /var/www/timeoverflow/vendor/bundle/ruby/2.6.0/gems/sshkit-1.8.1/lib/sshkit/backends/abstract.rb:15:in run' 25: from /var/www/timeoverflow/vendor/bundle/ruby/2.6.0/gems/sshkit-1.8.1/lib/sshkit/backends/abstract.rb:15:in instance_exec'
24: from /var/www/timeoverflow/vendor/bundle/ruby/2.6.0/gems/capistrano-3.4.0/lib/capistrano/tasks/git.rake:17:in block (3 levels) in <top (required)>' 23: from /var/www/timeoverflow/vendor/bundle/ruby/2.6.0/gems/sshkit-1.8.1/lib/sshkit/backends/abstract.rb:53:in execute'
22: from /var/www/timeoverflow/vendor/bundle/ruby/2.6.0/gems/sshkit-1.8.1/lib/sshkit/backends/abstract.rb:121:in create_command_and_execute' 21: from /var/www/timeoverflow/vendor/bundle/ruby/2.6.0/gems/sshkit-1.8.1/lib/sshkit/backends/abstract.rb:121:in tap'
20: from /var/www/timeoverflow/vendor/bundle/ruby/2.6.0/gems/sshkit-1.8.1/lib/sshkit/backends/abstract.rb:121:in block in create_command_and_execute' 19: from /var/www/timeoverflow/vendor/bundle/ruby/2.6.0/gems/sshkit-1.8.1/lib/sshkit/backends/netssh.rb:87:in execute_command'
18: from /var/www/timeoverflow/vendor/bundle/ruby/2.6.0/gems/sshkit-1.8.1/lib/sshkit/backends/netssh.rb:134:in with_ssh' 17: from /var/www/timeoverflow/vendor/bundle/ruby/2.6.0/gems/sshkit-1.8.1/lib/sshkit/backends/connection_pool.rb:38:in checkout'
16: from /var/www/timeoverflow/vendor/bundle/ruby/2.6.0/gems/sshkit-1.8.1/lib/sshkit/backends/connection_pool.rb:95:in create_new_entry' 15: from /var/www/timeoverflow/vendor/bundle/ruby/2.6.0/gems/net-ssh-2.9.2/lib/net/ssh.rb:207:in start'
14: from /var/www/timeoverflow/vendor/bundle/ruby/2.6.0/gems/net-ssh-2.9.2/lib/net/ssh.rb:207:in new' 13: from /var/www/timeoverflow/vendor/bundle/ruby/2.6.0/gems/net-ssh-2.9.2/lib/net/ssh/transport/session.rb:87:in initialize'
12: from /var/www/timeoverflow/vendor/bundle/ruby/2.6.0/gems/net-ssh-2.9.2/lib/net/ssh/transport/session.rb:213:in wait' 11: from /var/www/timeoverflow/vendor/bundle/ruby/2.6.0/gems/net-ssh-2.9.2/lib/net/ssh/transport/session.rb:213:in loop'
10: from /var/www/timeoverflow/vendor/bundle/ruby/2.6.0/gems/net-ssh-2.9.2/lib/net/ssh/transport/session.rb:215:in block in wait' 9: from /var/www/timeoverflow/vendor/bundle/ruby/2.6.0/gems/net-ssh-2.9.2/lib/net/ssh/transport/session.rb:178:in poll_message'
8: from /var/www/timeoverflow/vendor/bundle/ruby/2.6.0/gems/net-ssh-2.9.2/lib/net/ssh/transport/session.rb:178:in loop' 7: from /var/www/timeoverflow/vendor/bundle/ruby/2.6.0/gems/net-ssh-2.9.2/lib/net/ssh/transport/session.rb:200:in block in poll_message'
6: from /var/www/timeoverflow/vendor/bundle/ruby/2.6.0/gems/net-ssh-2.9.2/lib/net/ssh/transport/algorithms.rb:146:in accept_kexinit' 5: from /var/www/timeoverflow/vendor/bundle/ruby/2.6.0/gems/net-ssh-2.9.2/lib/net/ssh/transport/algorithms.rb:191:in send_kexinit'
4: from /var/www/timeoverflow/vendor/bundle/ruby/2.6.0/gems/net-ssh-2.9.2/lib/net/ssh/transport/algorithms.rb:200:in proceed!' 3: from /var/www/timeoverflow/vendor/bundle/ruby/2.6.0/gems/net-ssh-2.9.2/lib/net/ssh/transport/algorithms.rb:357:in exchange_keys'
2: from /var/www/timeoverflow/vendor/bundle/ruby/2.6.0/gems/net-ssh-2.9.2/lib/net/ssh/transport/algorithms.rb:357:in new' 1: from /var/www/timeoverflow/vendor/bundle/ruby/2.6.0/gems/net-ssh-2.9.2/lib/net/ssh/transport/kex/diffie_hellman_group1_sha1.rb:51:in initialize'
/var/www/timeoverflow/vendor/bundle/ruby/2.6.0/gems/net-ssh-2.9.2/lib/net/ssh/transport/kex/diffie_hellman_group1_sha1.rb:118:in generate_key': undefined method p=' for #OpenSSL::PKey::DH:0x00007f78cc0adf38 (NoMethodError)
Did you mean? p
(Backtrace restricted to imported tasks)
cap aborted!
NoMethodError: undefined method `p=' for #OpenSSL::PKey::DH:0x00007f78cc0adf38
Did you mean? p

Tasks: TOP => git:check => git:wrapper
(See full trace by running task with --trace)
The deploy has failed with an error: undefined method p=' for #<OpenSSL::PKey::DH:0x00007f78cc0adf38> Did you mean? p

@enricostano
Copy link
Contributor

Are you able to run this branch locally?

@sseerrggii
Copy link
Contributor

Yes @enricostano works locally

@dependabot dependabot bot force-pushed the dependabot/bundler/devise-4.7.1 branch from c4c4396 to 3ff310c Compare February 25, 2020 15:56
@dependabot dependabot bot force-pushed the dependabot/bundler/devise-4.7.1 branch from 3ff310c to 867368c Compare February 25, 2020 19:35
@markets
Copy link
Collaborator

markets commented Feb 25, 2020

Hello @sseerrggii,
This fixes a high severity security alert, maybe we should try to move it forward. Thanks!!

(dependabot automatically rebased the branch for us 👌)

@sseerrggii
Copy link
Contributor

Yes, now works fine 🙏

✔️

@sauloperez sauloperez merged commit e197891 into develop Feb 26, 2020
@dependabot dependabot bot deleted the dependabot/bundler/devise-4.7.1 branch February 26, 2020 17:04
@sauloperez sauloperez mentioned this pull request Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants