move weekly digest email to sidekiq-cron and remove whenever

[markets]

Closes #373
Closes coopdevs/timeoverflow-provisioning#24
Closes #544
Closes #548

EXTRA:

• update more dev deps: rubocop, byebug, fabrication, capybara, webdrivers
• fixing CI (feature specs)

INFRA CHANGES & TESTING
👀 #401 (comment)

[enricostano]

😍

[enricostano]

To test this we first need to solve coopdevs/timeoverflow-provisioning#36

[markets]

Ok @enricostano thanks! I think this will also close #369

[enricostano]

Cool @markets , many thanks for improving this PR! 💪

Just two questions:

1. What would be the best strategy to test it?
2. I guess we should plan some kind of pre-post deploy operations for production to remove the existent cron job, right?

[markets]

Hi @enricostano

1. the code inside the Job class is just a copy/pasta from the old Service class (with find_each instead of each), so in terms of logic, it should work exactly as it works now. To ensure that, I think we can use the Sidekiq UI, as cron jobs are displayed there and they have an "Enqueue Now" button:

2. We should remove the crontab line generated by the whenever gem, this can be done by hand (crontab -e) or using an option provided by the gem: whenever -c or --clear-crontab. We should ✂️ remove things in the provisioning system too: https://github.com/coopdevs/timeoverflow-provisioning/search?q=cron&type=Code.

Also, you commented in the past, we'll need to solve this first coopdevs/timeoverflow-provisioning#36.

Let me know what do you think and what can I do to help moving this forward!

[sseerrggii]

🤔 I think I will need som help to test that @enricostano also I think we have som troubles with push notifications, so one day we can sit together and test thinks looking at Sidekiq 🙏

[enricostano]

Blocked by coopdevs/timeoverflow-provisioning#36

[markets]

Just updated with current develop! I also "unblocked" this PR, as the main blocker coopdevs/timeoverflow-provisioning#36 was already solved.

[sseerrggii]

Testing it on staging i get this error

[markets]

Yay! Travis is passing ✅ now! It's already failing in master, and not related to this branch, but I fixed it here in order to have green build for this branch.

@sseerrggii I also fixed the error you got last day. Thanks!

[sauloperez]

Thanks a ton @markets ! what a mess with the locale 🙈 @mperezv this is relevant to you ☝️

[sseerrggii]

Now Works fine, thanks @markets 💚

[sauloperez]

Finally up and working in production! thanks a lot @markets 🎉 ! TO is now cron-free and relies on Sidekiq for all kinds of async stuff 👏