Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom error pages #299

Merged
merged 2 commits into from
Mar 2, 2018
Merged

Custom error pages #299

merged 2 commits into from
Mar 2, 2018

Conversation

markets
Copy link
Collaborator

@markets markets commented Jan 28, 2018

Closes #265

Implement custom error pages: 404 and 500.

To test it locally:

NOTE: localeapp translations integrated here 👉 #301

404

captura de pantalla 2018-01-28 a la s 22 11 42

500

captura de pantalla 2018-02-05 a la s 20 19 34

@markets
Copy link
Collaborator Author

markets commented Jan 28, 2018

@sseerrggii @sauloperez I made a signup on localeapp, but I think I can't create new translation keys. Could you please help me with this 😄?

We'll need 4 new segments:

  • 404 title (errors.not_found.title)
  • 404 description (errors.not_found.description)
  • 500 title (errors.internal_server_error.title)
  • 500 description (errors.internal_server_error.description)

@sauloperez
Copy link
Collaborator

sauloperez commented Jan 28, 2018

I'm crying of joy @markets! It's wonderful to have you back! 🎉👏💪. We'll take a look tomorrow.

@sauloperez sauloperez self-assigned this Jan 29, 2018
Copy link
Collaborator

@sauloperez sauloperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markets you should add the copies in config/locales/en.yml. Then we'll see them in localeapp and we'll be able to translate them.

@sauloperez sauloperez removed their assignment Jan 29, 2018
@markets
Copy link
Collaborator Author

markets commented Jan 29, 2018

@sauloperez i18n integration pushed => 11010c6

@sauloperez
Copy link
Collaborator

Perfect @markets ! Perfect timing for this. We'll hand it over to the new testing team we're building 👉 http://community.coopdevs.org/t/timeoverflow-testing-team/345/6

sseerrggii added a commit that referenced this pull request Jan 29, 2018
Includes the keys added in PR #299.
@sseerrggii sseerrggii mentioned this pull request Jan 29, 2018
@enricostano
Copy link
Contributor

@sseerrggii I deployed this branch to https://staging.timeoverflow.org for the test team to test it 💪

@markets sorry I had to rebase with current develop and push --force 😬

enricostano pushed a commit that referenced this pull request Feb 21, 2018
Includes the keys added in PR #299.
@sseerrggii
Copy link
Contributor

Tested: Work Fine, thanks @markets

@sseerrggii sseerrggii added this to the 1.3.2 milestone Mar 2, 2018
@sauloperez sauloperez merged commit 1478aac into develop Mar 2, 2018
@sauloperez sauloperez mentioned this pull request Mar 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants