Update deps - 2nd round #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit f41ec64) Conflicts: Gemfile Gemfile.lock
…because of our old infra (shelly cloud). We are now running pro with Unicorn and WEBrick should be enough for dev (https://schneems.com/2017/08/01/is-webrick-webscale/). Thin is nice, but it depends on eventmachine and this a big dep we can avoid. I also update the Procfile to run Unicorn on Heroku (https://devcenter.heroku.com/articles/rails-unicorn#procfile).
…n they added the BUNDLED WITH thing
|
Awesome @markets ! 🤘 |
sauloperez
approved these changes
Jan 26, 2018
sauloperez
approved these changes
Jan 29, 2018
Conflicts: Gemfile.lock
|
Great @markets ! that Rubocop vulnerability annoys me. We hope to find some time to test this, hopefully, next week. |
It was totally outdated regarding current DB schema. I neither found any reference on the infrastructure side (provisioning repo). So time to ✂️
…m from runtime deps since it's not used for production (nor staging) at this point. And I can't found either any reference on the wiki.
|
😍 |
…have 1 static page, so this simple approach (1 controller) should be enough.
|
@sseerrggii deployed to https://staging.timeoverflow.org |
|
I did a complete test and everything seems to work well 👍 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's give our Gemfile and deps some more love ❤️ !! Inline with #294.
Supersedes and closes #273 (I cherry-picked the first commit from @knoopx to keep credit 😃 and fixed the merge with current
develop).Deps changes
Rails4.2.10 (latest 4.2 stable release) ~> from Update deps #273ActiveAdmin~> from Update deps #273RSpecnokogiriquiet_assets(now we can do the same withsprockets-rails3.1+)sass-rails(closes Fix deprecation warning due to sass-rails-5.0.4 #297)http_accept_languagethin,WEBrickisn't that bad for dev 🙌 and updated Procfile (9192610)memcachier(closes Remove memcachier gem #326 and Remove Memcachier gem #204)Rubocopto fix a security alert (623fb28) (closes Update Rubocop due to vulnerability #280). Also, removed.hound.ymlfile since we're not using it at this moment.Deviseto latest version (75aa85d)better_errors(andbinding_of_caller) (a1f68f8)Kaminari, necessary to make it compatible with latest (and updated also here)ActiveAdminversion (da98d84)Prawn(fda4eba)foreman(8394923)high_voltagewith a custom solution (2a94cf6)Extra
db/structure.sql(74add4c)config/deploy/shelly/after_successful_deploy(c866d33)app/views/application/_organization_list.html.erb(0e53f23)Note
🙏 I know this probably too big, but I think it make sense to test the whole thing together. I played (with most of touched parts) a lot locally and I found 0 errors or exceptions. Anyway, would be really nice a very good review and tests on staging.
@sauloperez you got it 👉 #294 (comment) not so small finally 😛
Also, fixes partially #289.