Try to fix multiple printer tickets #1903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladimir-8
approved these changes
Oct 17, 2024
| @@ -25,7 +25,8 @@ const Comp = ({ order, isPrinterConnected, onPrinterClick, printOrder }) => { | |||
| {isPrinterConnected && ( | |||
| <Button | |||
| endIcon={<Icon as={FontAwesome} name="print" size="sm" />} | |||
| onPress={printOrder}> | |||
| onPress={printOrder} | |||
| isDisabled={disablePrintButton}> | |||
There was a problem hiding this comment.
To be honest, I don't see much value in passing these props through three components (Order.js > OrderHeading.js > OrderButtons.js). I would put them in OrderButtons directly
| @@ -244,3 +244,8 @@ export const selectIsActionable = createSelector( | |||
| ); | |||
| }, | |||
| ); | |||
|
|
|||
| export const selectIsPrinting = createSelector( | |||
There was a problem hiding this comment.
There is a selector called selectPrintingOrderId. It can be used either here or directly from a React component
vladimir-8
reviewed
Oct 17, 2024
| return state; | ||
| return { | ||
| ...state, | ||
| printingOrderId: null, |
There was a problem hiding this comment.
My idea was that only printFulfilled/printRejected actions with the same order ID as in printPending should reset the state (assuming that printing is sequential)
There was a problem hiding this comment.
Did you see a situation when it was not working?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.