Barcode scanner

[r0xsh]

Linked with: coopcycle/coopcycle-web#4512

[Atala]

tested:

• scan an assigned task -> pop up shows unassign/ok
  if i click unassign then it unassigns but I am not redirected back to the "My tasks" screen
  if i click OK then nothing happens, the popup close and no information shows up in task field, i am stuck on the empty barcode screen + barcode scanning does not seem to work a second time

scanning an unassigned task -> it assigns directly to me without a popup opening, is that normal?

scanning a task assigned to another rider -> pop up opens and i can assign it to myself

so all in all here are the problems :

• what does the "ok" button means to the user in the various popups? it is more a yes/no question no? so it should be a "NO" button
• when clicking on "ok" nothing shows, nothing happens (and i think you can not scan anymore)
• after clicking unassign/assign/assign to me then you should be redirected to the tasklist or to the map (the page you were originally on)
• how one is supposed to complete a task? when i scan a task that is assigned to me then i can only unassign, not complete. also in the UI/UX when the task is assigned to me, complete the task should be the main choice

[Atala]

maybe write a more helpful message? like "Allow camera in app setting to use the barcode scanner"?

[r0xsh]

if i click unassign then it unassigns but I am not redirected back to the "My tasks" screen

Yup this is intentional behavior, but this feature is hard to design since it can be used is many scenarios. But i think is can be solve by having a "batch scanning mode".
The feature was originally thought for doing batch scan at morning when the rider prepares his route. But you're right this create some friction in a rider workflow.

if i click OK then nothing happens, the popup close and no information shows up in task field, i am stuck on the empty barcode screen + barcode scanning does not seem to work a second time

Just go back, no ?

scanning an unassigned task -> it assigns directly to me without a popup opening, is that normal?

Yup expected behavior, the alert is shown only when the task is already assigned to self or another rider.

what does the "ok" button means to the user in the various popups? it is more a yes/no question no? so it should be a "NO" button

It just close the modal, maybe No label will be clearer 👍

when clicking on "ok" nothing shows, nothing happens (and i think you can not scan anymore)

You can't scan twice the same barcode ? But i agree this is a bit annoying. I already thought about a potential fix for that: https://github.com/coopcycle/coopcycle-app/pull/1834/files#diff-044fc4e1bab6b1c678131dde9f7719a282973acbf04d245c16c2fd26cb335d8aR248-R254

how one is supposed to complete a task? when i scan a task that is assigned to me then i can only unassign, not complete. also in the UI/UX when the task is assigned to me, complete the task should be the main choice

The task should be in DOING status to trigger the complete behavior

[Atala]

in the new "task complete UI"

• I think the phone label to call directly should be next to the phone number on its right (also more easily reachable by right hand thumb there)
• how one can mark task as "DONE" without incident?

[Atala]

(check yarn lint errors)