-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: broken trigger.dev templates #4724
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Winne4r
changed the title
FIX: trigger.dev templates - wrong key length issue
[WIP] FIX: trigger.dev templates - wrong key length issue
Jan 3, 2025
Winne4r
changed the title
[WIP] FIX: trigger.dev templates - wrong key length issue
FIX: trigger.dev templates - wrong key length issue
Jan 3, 2025
I also added some missing config, with this changes I finally managed to successfully run the background task. |
Winne4r
changed the title
FIX: trigger.dev templates - wrong key length issue
FIX: broken trigger.dev templates
Jan 3, 2025
# Conflicts: # templates/compose/trigger.yaml
peaklabs-dev
added
the
⚙️ Service
Issues requesting or PRs adding/fixing service templates.
label
Jan 6, 2025
peaklabs-dev
requested changes
Jan 14, 2025
peaklabs-dev
added
💤 Waiting for changes
PRs awaiting changes from the author.
and removed
💤 Waiting for changes
PRs awaiting changes from the author.
labels
Jan 14, 2025
peaklabs-dev
changed the title
FIX: broken trigger.dev templates
fix: broken trigger.dev templates
Jan 16, 2025
Thank you for the PR! |
github-actions
bot
removed
the
⚙️ Service
Issues requesting or PRs adding/fixing service templates.
label
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The latest template was unusable due to the following issues:
I discovered that the issue was related to wrong length of keys:
https://github.com/triggerdotdev/docker/blob/b2c2949ac923b91f86fe2014059e531fae1d9c33/.env.example#L64
As you can see these secrets should be generated with:
openssl rand -hex 16
which is equal to 32 chars string