Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appwrite fix #4226

Merged
merged 2 commits into from
Nov 12, 2024
Merged

appwrite fix #4226

merged 2 commits into from
Nov 12, 2024

Conversation

djsisson
Copy link
Contributor

@djsisson djsisson commented Nov 9, 2024

Changes

  • add missing services needed for 1.6

Issues

  • see discord:

https://discord.com/channels/459365938081431553/1304886044574879865/1304907226216927253

@djsisson
Copy link
Contributor Author

djsisson commented Nov 9, 2024

PLEASE note @peaklabs-dev or @andrasbacsai

Strip prefix needs to be turned off for console and realtime in order for this to work, i assume its a bug as instead of strip pref removing just / it removes the whole path prefix

i can't think of a way to build this into the compose itself

@peaklabs-dev peaklabs-dev added the ⚙️ Service Issues requesting or PRs adding/fixing service templates. label Nov 10, 2024
@kuzerno1
Copy link

This is working after turning off strip prefix as stated for console and realtime. But _APP_OPENSSL_KEY_V1 is missing maybe we can use like _APP_OPENSSL_KEY_V1=${SERVICE_PASSWORD_64_OPENSSLKEY} in the compose file so that it will be generated.

And I think that we need to replace $SERVICE_FQDN_APPWRITE with $SERVICE_URL_APPWRITE. This is because SERVICE_FQDN and SERVICE_URL are mixed up. So with $SERVICE_URL_APPWRITE you get the domain without the http(s).

After this change when you create a new function you don't get http or https prefix in the generated url.

@djsisson
Copy link
Contributor Author

@kuzerno1 so anything with APP_DOMAIN needs to be SERVICE_URL is that correct? ok ill make new pr

@kuzerno1
Copy link

Yes that is correct. I have tested the new compose file and everything is working now inside appwrite, nice!

@peaklabs-dev peaklabs-dev self-assigned this Nov 12, 2024
@peaklabs-dev peaklabs-dev changed the base branch from next to services November 12, 2024 12:44
@peaklabs-dev
Copy link
Member

I will merge this and fix the gzip one in a big refactor of docker labels I am currently working on (will take some time).

@peaklabs-dev peaklabs-dev merged commit 5f04aee into coollabsio:services Nov 12, 2024
1 check passed
@github-actions github-actions bot removed the ⚙️ Service Issues requesting or PRs adding/fixing service templates. label Nov 12, 2024
@djsisson djsisson deleted the appwrite-fix branch November 12, 2024 13:18
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants