Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Docker Swarm - Future warning (--detach) #4146

Closed
XenonR opened this issue Nov 6, 2024 · 6 comments · Fixed by #4941
Closed

[Bug]: Docker Swarm - Future warning (--detach) #4146

XenonR opened this issue Nov 6, 2024 · 6 comments · Fixed by #4941

Comments

@XenonR
Copy link

XenonR commented Nov 6, 2024

Error Message and Logs

Manager

Since --detach=false was not specified, tasks will be created in the background.
In a future release, --detach=false will become the default.
failed to update service coolify-proxy_traefik: Error response from daemon: rpc error: code = Unknown desc = update out of sequence

Worker

Since --detach=false was not specified, tasks will be created in the background.
In a future release, --detach=false will become the default.
this node is not a swarm manager. Use "docker swarm init" or "docker swarm join" to connect this node to swarm and try again

Steps to Reproduce

  1. Encountered with Docker version 27.3.1, build ce12230
  2. Docker Swarm was already setup.
  3. Add a Swam Manager or Swarm Worker in Coolify.
  4. Validate Server & Install.

Example Repository URL

No response

Coolify Version

v4.0.0-beta.360

Are you using Coolify Cloud?

No (self-hosted)

Operating System and Version (self-hosted)

Debian GNU/Linux 12 (bookworm)

Additional Information

The same error occurs when trying to deploy something.

@XenonR XenonR added 🐛 Bug Reported issues that need to be reproduced by the team. 🔍 Triage Issues that need assessment and prioritization. labels Nov 6, 2024
@XenonR
Copy link
Author

XenonR commented Nov 6, 2024

What is the idea or deployment goal?

if ($server->isSwarm()) {

From the docker command alone I would assume we need to change if ($server->isSwarm()) { to if ($server->isSwarmManager()) {

@XenonR
Copy link
Author

XenonR commented Nov 7, 2024

Related to #4130
After correcting this issue we encounter traefik:v2 configuration but want to use traefik:v3.1

@XenonR
Copy link
Author

XenonR commented Nov 7, 2024

After addressing #4146 and #4130 the proxy is able to start at a docker manager, but still fails on a worker with:

 traefik Pulling 
 traefik Pulled 
 Container proxy-traefik-1  Recreate
 Container proxy-traefik-1  Recreated
 Container proxy-traefik-1  Starting
Error response from daemon: container aefeb1567f40d5e71bd78c5c348146c3a8851eaf1dfac6aeaa7d60a159066e06: endpoint join on GW Network failed: driver failed programming external connectivity on endpoint gateway_78aa55990e7a (279cdf7bc78f9f8f58e27930e1ef66c3d6b07ae73e90e27d7ed2c65fc2fa2959): failed to bind port 0.0.0.0:80/tcp: Error starting userland proxy: listen tcp4 0.0.0.0:80: bind: address already in use

netstat

tcp6       0      0 :::80                   :::*                    LISTEN      0          331866     1685/dockerd
tcp6       0      0 :::443                  :::*                    LISTEN      0          331327     1685/dockerd
tcp6       0      0 :::8080                 :::*                    LISTEN      0          331358     1685/dockerd

On worker nodes it should not be required to deploy the proxy. As long as the ingress routing mesh is used the proxy of the manager will also be reachable from the workers.

I need someone who explains the desired design to continue.

Development branch: https://github.com/bit-in-gmbh/coolify/tree/swarm

@hederson
Copy link
Contributor

Hi, @andrasbacsai, @peaklabs-dev

I saw that @XenonR suggested the change to fix on his comment and didn't open a PR for that.

Can I open a PR with his change? I didn't test yet, but the changes looks good so far.

@hederson
Copy link
Contributor

PR created #4938

@github-actions github-actions bot removed 🐛 Bug Reported issues that need to be reproduced by the team. 🔍 Triage Issues that need assessment and prioritization. labels Jan 28, 2025
@sponte
Copy link

sponte commented Feb 6, 2025

It might be worth mentioning that --detach flag is not supported until v26 I believe, and the coolify docs in their swarm setup example mentioned version 24 which will not work https://coolify.io/docs/knowledge-base/docker/swarm/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants