Fix memory leak! #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any news here? It'd be nice to see this released... |
Heartbeat response
…ll be called correctly, and potential memory leak fixes
Handle out-of-order CancelOk Handle server-sent Nack Add missing accessors, e.g. is_open and is_active and verbose Fix a potential memory leak
RT#106550 Add no_ack param to get()
Kwalitee complains that the non main modules have regressed in version, as they no version number.
Be consistent with other use of cpanm
Use Dist::Zilla::Plugin::OurPkgVersion
Pass peername to AnyEvent::Handle so that TLS peer validation is possible
Add "nodelay" option
Ordinary Perl runs into trouble with Alien::LibXML failing under Windows. Strawberry Perl has libxml already installed. Also avoid shell globbing, as that doesn't work under Windows (at least not without bash.) Upgrades actions-setup-perl to v1.4.0 too.
Use Strawberry Perl to test under Windows
Fix by Eugen Konkov.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hiya
Turns out the entire contents of every message you get (+ some more) is leaked.
The change here fixes this by removing the circular ref.