Migrate to the unified STORAGES setting added in Django 4.2

[browniebroke]

Description

There was a PR open for it in #4457 but the author closed it before it could be merged. Re-opening it with commits attributions.

Checklist:

• I've made sure that tests are updated accordingly (especially if adding or updating a template option)
• I've updated the documentation or confirm that my change doesn't require any updates

Rationale

Fix #4443

[jkaeske]

The code looks fine to me.
I made one comment to specify the object storage options directly in the settings file as recommended in the django-storages docs.
Is there something missing or could we get this merged?

[jkaeske]

To avoid relying on the instantiated storage classes, should we provide the settings here directly like so:

"default": {
    "BACKEND": "storages.backends.s3.S3Storage",
    "OPTIONS": {
        "location": "static",
        "default_acl": "public-read",
    },
},
"staticfiles": {
    "BACKEND": "storages.backends.s3.S3Storage",
    "OPTIONS": {
        "location": "media",
        "file_overwrite": False,
    },
},

[browniebroke]

Yes great suggestion

[browniebroke]

Is there something missing or could we get this merged?

Last time I tried to deploy this change I hit some permission issues with AWS S3, but I couldn't figure out if it was caused by this PR or soemthing that changed in AWS.

If you could try out a combination or 2 you care about, and feedback your results, that would be very helpful. You can run it against my branch with: cookiecutter https://github.com/browniebroke/cookiecutter-django --checkout migrate/unified-storages-setting

[jkaeske]

@browniebroke was this perhaps the error that you have seen?
botocore.exceptions.ClientError: An error occurred (AccessControlListNotSupported) when calling the PutObject operation: The bucket does not allow ACLs

There can also be an issue if the bucket is in the new eu-central-2 Zurich region, since it is opt-in

But other than that, if ACLs are enabled for the bucket, there are no permission issues in AWS during my test

[jkaeske]

I am happy to help change the settings file and delete storages.py if you like.
It should be straightforward from here to get this merged.

[browniebroke]

I am happy to help change the settings file and delete storages.py if you like. It should be straightforward from here to get this merged.

It's now merged so feel free to create a new PR to do these changes 👍🏻 Thanks for your help in getting this reviewed.

[foarsitter]

Thanks @browniebroke!

[jkaeske]

I am happy to help change the settings file and delete storages.py if you like. It should be straightforward from here to get this merged.

It's now merged so feel free to create a new PR to do these changes 👍🏻 Thanks for your help in getting this reviewed.

Thanks to you @browniebroke !
I will create a new PR for the other changes