-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove browser-sync add Django browser reload #3750
base: master
Are you sure you want to change the base?
Conversation
Happy for people to contribute to the documentation. Not sure where/how to talk about this change |
I've done some basic testing and wasn't able to get it working (tried with and without Docker). Here are the steps I followed:
Did I miss a step or are we actually missing something? |
I think there are some issues with asgi. Any suggestions? How to get this work with uvicorn as well? |
For me, the reload process was getting stuck at the following:
After looking a bit into this, I found this issue: I added
Note the following line:
This indicates that there is a running task that is not shutting down when reload is triggered. After some debugging, I figured out that it only occurs when we enable For now, I'm just using |
Fix #3745
Description
Remove Javscript based auto reload and use a python based one django-browser-reload
Checklist:
Rationale
see #3745