Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename browsers option to overrideBrowserslist for postcss #273

Merged
merged 7 commits into from
Jul 24, 2019
Merged

Rename browsers option to overrideBrowserslist for postcss #273

merged 7 commits into from
Jul 24, 2019

Conversation

landonreed
Copy link
Contributor

This removes a noisy warning when mastarm is run. References postcss/autoprefixer#1216

@landonreed landonreed requested a review from evansiroky July 12, 2019 21:11
@codecov-io
Copy link

codecov-io commented Jul 12, 2019 •
edited
Loading

Codecov Report

Merging #273 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #273   +/-   ##
=======================================
  Coverage   64.36%   64.36%           
=======================================
  Files          19       19           
  Lines         449      449           
  Branches       81       81           
=======================================
  Hits          289      289           
  Misses        137      137           
  Partials       23       23
Impacted Files Coverage Δ
lib/babel-config.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccc4098...e6ff50c. Read the comment docs.

@evansiroky
Copy link
Contributor

Are you sure this works? I tried changing this in the node_modules file of mastarm and the warnings are still occurring.

@evansiroky evansiroky assigned landonreed and unassigned evansiroky Jul 17, 2019
@landonreed
Copy link
Contributor Author

Ah, no I didn't actually try it out on a project. Let me try and see what else this needs.

@landonreed
Copy link
Contributor Author

@evansiroky, I just tried this out on the example project for otp-rr and it did in fact remove the warning. It also fixed an issue building/babelifying the js, so I'd like to move forward with this fix.

@landonreed
Copy link
Contributor Author

Hold that thought, I just did a rm -rf on mastarm's node modules and it's no longer working the same. Stay tuned...

@landonreed landonreed mentioned this pull request Jul 23, 2019
Merged
@landonreed landonreed assigned evansiroky and unassigned landonreed Jul 23, 2019
evansiroky
evansiroky reviewed Jul 23, 2019
View reviewed changes
lib/css-transform.js Outdated Show resolved Hide resolved
evansiroky
evansiroky suggested changes Jul 23, 2019
View reviewed changes
Copy link
Contributor

@evansiroky evansiroky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for #273 (comment)

@evansiroky evansiroky assigned landonreed and unassigned evansiroky Jul 23, 2019
@landonreed landonreed requested review from evansiroky and removed request for evansiroky July 24, 2019 13:29
@landonreed landonreed merged commit 0a8fec1 into dev Jul 24, 2019
@landonreed landonreed deleted the fix-browsers-option branch July 24, 2019 14:12
@landonreed landonreed mentioned this pull request Jul 24, 2019
Merged
@trevorgerhardt
Copy link
Member

🎉 This PR is included in version 5.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evansiroky evansiroky evansiroky requested changes

Assignees

@landonreed landonreed

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@landonreed @codecov-io @evansiroky @trevorgerhardt