Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: navbar overlap in mobile devices #548

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Chetan-KK
Copy link

@Chetan-KK Chetan-KK commented Oct 14, 2023

fixed #547

@lorenzodianni
Copy link
Member

Hi @Chetan-KK , thanks for the PR!
Why did you choose 7rem? It could be too much on some devices

What is the device/use case you need to fix?

@damianopetrungaro
Copy link
Member

@lorenzodianni is this still actionable? If @Chetan-KK is not available would you mind patching this issue?

@lorenzodianni
Copy link
Member

Hi @Chetan-KK, a better approach might be to change the SCSS variable $welcome-min-height to 800px instead of 450px. This way, we don't apply any padding (which is too generic for certain devices) but rely on the height of the container, ensuring that all the spaces remain uniform.

@damianopetrungaro I can open a PR in a couple of days if @Chetan-KK is unavailable

@Chetan-KK
Copy link
Author

Hi @lorenzodianni, I've made a pr with variable value changed can you please review it once for merge

@lorenzodianni
Copy link
Member

Hi @Chetan-KK, please update #617 with the new variable value, I see only linting changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: navigation bar is not responsive on smaller devices
3 participants