Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support a wording change made to git status in git v2.9.1 #140

Merged
merged 1 commit into from
Nov 13, 2016
Merged

fix: support a wording change made to git status in git v2.9.1 #140

merged 1 commit into from
Nov 13, 2016

Conversation

dsole
Copy link
Contributor

@dsole dsole commented Nov 13, 2016

Simply changed the assertion regex of the "commits all staged files" unit test to support a wording change made to git status in git v2.9.1 from "working directory" to "working tree"

See:
git/git@2a0e6cd

Fixes #138

@coveralls
Copy link

coveralls commented Nov 13, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 5b3b142 on dsole:138-git-status-wording into 8e4ec4a on conventional-changelog:master.

@stevemao
Copy link
Member

stevemao commented Nov 13, 2016 •
edited
Loading

What about removing , working (directory|tree) clean\n? (Just my suggestion, I'd like to see if people like it)

@bcoe bcoe merged commit 80004ec into conventional-changelog:master Nov 13, 2016
@bcoe
Copy link
Member

bcoe commented Nov 13, 2016

@stevemao whoops, hit merge before reading your comment; I'm okay with leaving (directory|tree) if you are.

@dsole thank you very much for the contribution 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dsole @coveralls @stevemao @bcoe