Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promises in tests are not waited for #51

Closed
Tapppi opened this issue Jun 8, 2016 · 0 comments
Closed

Promises in tests are not waited for #51

Tapppi opened this issue Jun 8, 2016 · 0 comments
Labels
bug

Comments

@Tapppi
Copy link
Member

Tapppi commented Jun 8, 2016 •
edited
Loading

Mock-git returns promises, but they aren't returned except in one of the test cases, causing a race condition between the .then() chained to the promise and the afterEach hook. This leads to possible corruption of root package.json and CHANGELOG.md.
@Tapppi Tapppi added the bug label Jun 8, 2016
@Tapppi Tapppi mentioned this issue Jun 8, 2016
Closed
Tapppi added a commit to Tapppi/standard-version that referenced this issue Jun 8, 2016
@Tapppi
test: fix async mock-git tests
2daa0f3 
Return promises from mock-git to remove race condition between the promise
and afterEach hook.

Fixes conventional-changelog#51
@Tapppi Tapppi mentioned this issue Jun 8, 2016
Merged
tomchentw pushed a commit that referenced this issue Jun 8, 2016
@Tapppi @tomchentw
test: fix async mock-git tests (#54)
5e56185 
* Closes #51 
* Closes #54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Tapppi