chore: remove unused configs #991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armano2
commented
Feb 10, 2020
| @@ -1,3 +1,2 @@ | |||
| workspaces-experimental "true" | |||
There was a problem hiding this comment.
Starting Yarn 1.0 Workspaces are enabled by default and you may not need to set the below config. Refer to the updated steps at the following location https://yarnpkg.com/lang/en/docs/workspaces/
2017/08/02
https://classic.yarnpkg.com/blog/2017/08/02/introducing-workspaces/#setting-up-workspaces
off-topic: they released/releasing v2 of yarn
There was a problem hiding this comment.
Yes, we might have a look. Last I checked the ts interop was not great
armano2
commented
Feb 10, 2020
Comment on lines
-14
to
-21
| "babel": { | ||
| "presets": [ | ||
| "babel-preset-commitlint" | ||
| ], | ||
| "ignore": [ | ||
| "**/*.test.js" | ||
| ] | ||
| }, |
There was a problem hiding this comment.
i missed this one last time
armano2
commented
Feb 10, 2020
armano2
commented
Feb 10, 2020
Comment on lines
-1
to
-6
| os: windows | ||
| language: node_js | ||
| node_js: | ||
| - lts/* | ||
| before_script: | ||
| - yarn build |
There was a problem hiding this comment.
travis is no longer used
armano2
commented
Feb 10, 2020
Comment on lines
31
to
35
| "dependencies": { | ||
| "@commitlint/config-patternplate": "^8.3.4", | ||
| "@commitlint/config-patternplate": "^8.3.4" | ||
| }, | ||
| "devDependencies": { | ||
| "@commitlint/utils": "^8.3.4" |
There was a problem hiding this comment.
there is no reason to require utils when installing config,
utils is a dev package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove no longer used/needed configs and fix
@alias/commitlint-config-patternplatedependenciesMotivation and Context
Usage examples
How Has This Been Tested?
Types of changes
Checklist: