Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(resolve-extends): replace lodash/omit with spread #988

Merged
merged 1 commit into from
Feb 10, 2020

Conversation

armano2
Copy link
Contributor

@armano2 armano2 commented Feb 10, 2020

replace lodash/omit with spread

Description

This syntax is not supported in targeted version of node but typescript does transpile it in ~same way as babel does

Motivation and Context

lodash/omit has huge performance impact on code and new syntax (transpiled) is up to 10 times faster
omit is also on roadmap to be removed from lodash

lodash/lodash#2930
https://github.com/lodash/lodash/wiki/Roadmap

Usage examples

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants