feat(prompt-cli): check stage before prompt #51 #461
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
escapedcat
commented
Oct 5, 2018
| @@ -1,7 +1,7 @@ | |||
| #!/usr/bin/env node | |||
| const execa = require('execa'); | |||
| const meow = require('meow'); | |||
| const prompter = require('@commitlint/prompt').prompter; | |||
| const {prompter} = require('@commitlint/prompt'); | |||
There was a problem hiding this comment.
this is due to linting
|
I guess adding tests can't hurt anyone 😄 Can you add them too, or do you need some help with that? |
|
@byCedric sorry, saw your reply way too late. Added a basic test. Please have a look and let me know if that's ok. I'm still in the phase of getting to know the project a bit better and how to deal with the setup. |
|
I went ahead and added the two missing deps causing the lint in https://github.com/marionebl/commitlint/pull/495 The PR looks very good, thanks! Will merge via the follow up when CI yields green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@marionebl i just added exactlty you code. not sure if there's more to do. tests? nicer syntax?