Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes #438
Motivation and Context
I've added edge case-ignores to both
@commitlint/rules
's subject-case rule as well as@commitlint/ensure
's case. The reason for putting ignores in 2 places are these.You said that we should ignore all characters not matching
/^[a-z]/i
from the case rules in general.This was my initial thought of putting an ignore/exception into the
/ensure
package. Unfortunately, this conflicted with the test ofLOWERCASE
(with backtick), so I had to change it to ignore/^[0-9]/
.In the subject case you can negate the rule
Due to the negation happening in the
/rules
package, and not/ensure
, I had to also include the ignore here. I've tested it with both the!a-z
as well as0-9
ignore pattern, and here we actually could use the!a-z
exclusion rule.subjectCase('1.0.0', 'never', 'lowercase') === true
subjectCase('1.0.0', 'always', 'lowercase') === true
Usage examples
How Has This Been Tested?
See motivation & context
Types of changes
Checklist: