Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate @nrwl/tao to nx following 13.9.0 release #3135

Merged

Conversation

fguitton
Copy link
Contributor

@fguitton fguitton commented Apr 22, 2022

Description

This PR moves support for Nx 14.

See #3132

Motivation and Context

The Nx team has been working to consolidate their CLI related tools into the nx package.
Specifically we are looking at commit 6f038e.

As of version 13.9.0 they have released a migration path for this within Nx.

Now that Nx 14.0.0 has been release we need to make sure we transition the @commitlint/config-nx-scopes as well.

This should largely be considered a breaking change even if some level of backward compatibility is possible depending on the user existing workspace configuration.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@fguitton fguitton force-pushed the chore/upgrade-tao branch from bb97b35 to cc6d75a Compare April 22, 2022 11:24
@fguitton
Copy link
Contributor Author

@escapedcat The floor is yours ! 🕺🏼

@escapedcat
Copy link
Member

escapedcat commented Apr 23, 2022

Thanks for your fast response and support on this @fguitton !

As you indicated, this will be a breaking change.
I'm thinking of pushing out another last 16.x version and then create 17.x with this PR and #3128 together.
What do you think?

@fguitton
Copy link
Contributor Author

and then create 17.x with this PR and #3128 together

Sounds perfectly reasonable to me !
In the meantime nobody should be impacted under Nx 14 as everything is being temporarily re-exported in @nrwl/tao/src/shared/workspace.ts.

Thank you for keeping on top of it all 👏🏼

@andersonba
Copy link

hey guys, any news?

@escapedcat
Copy link
Member

hey guys, any news?

Last 16.x was published yesterday. Next up is 17.0.0. During the next days.

@escapedcat
Copy link
Member

@fguitton sorry, can't tag you on the other PR. Would you mind having a look at: #3155
Only if you have time for this though.

@escapedcat
Copy link
Member

@fguitton would you mind rebasing? Merged "drop node v12"

@fguitton fguitton force-pushed the chore/upgrade-tao branch from e143ad5 to fad7061 Compare May 15, 2022 07:20
@escapedcat
Copy link
Member

Arr, sorry, didn't notice. Please one more time 😊

@fguitton fguitton force-pushed the chore/upgrade-tao branch from fad7061 to 5ce1173 Compare May 16, 2022 07:51
@fguitton fguitton force-pushed the chore/upgrade-tao branch from 5ce1173 to 94efa64 Compare May 16, 2022 07:55
@escapedcat escapedcat merged commit daeeb49 into conventional-changelog:master May 16, 2022
@escapedcat
Copy link
Member

🎉 ❤️ Thanks!

@fguitton
Copy link
Contributor Author

🎉 ❤️ Thanks!

You're most welcome ! Looking forward to what's next ! 😋

@escapedcat
Copy link
Member

Released, please give it a try

@jaytavares
Copy link
Contributor

@fguitton Thanks for doing this! 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants