-
Notifications
You must be signed in to change notification settings - Fork 913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chinese scopes cause error #399
Labels
Comments
marionebl
added a commit
that referenced
this issue
Nov 30, 2018
#496) * fix: fall back to conventional commit-parser settings for missing keys BREAKING CHANGE This potentially changes implicit commitlint behaviour users may have relied on in earlier versions. Instead of falling back to the builtin commit-parser defaults we now default all keys to conventional-changelog-angular. * test: add case for #399 * chore: update yarn.lock * test: sort result lists
@escapedcat tested against master, and issue seem to be fixed |
@miadwang closing this for now. Please reopen if you have issues with this again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected Behavior
Chinese scopes acceptable
Current Behavior
Chinese scopes cause error
husky > npm run -s commitmsg (node v9.8.0)
⧗ input:
fix(面试评价): 测试
✖ message may not be empty [subject-empty]
✖ type may not be empty [type-empty]
✖ found 2 problems, 0 warnings
husky > commit-msg hook failed (add --no-verify to bypass)
If scope is English, e.g.: fix(english): 测试, lint will pass
Affected packages
Possible Solution
Steps to Reproduce (for bugs)
commitlint.config.js
Context
Your Environment
commitlint --version
git --version
node --version
The text was updated successfully, but these errors were encountered: