-
Notifications
You must be signed in to change notification settings - Fork 913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The body is truncated #3428
Labels
Comments
7 tasks
tehraninasab
added a commit
to tehraninasab/commitlint
that referenced
this issue
Jan 3, 2023
tehraninasab
added a commit
to tehraninasab/commitlint
that referenced
this issue
Jan 3, 2023
tehraninasab
added a commit
to tehraninasab/commitlint
that referenced
this issue
Jan 3, 2023
tehraninasab
added a commit
to tehraninasab/commitlint
that referenced
this issue
Jan 3, 2023
tehraninasab
added a commit
to tehraninasab/commitlint
that referenced
this issue
Jan 3, 2023
In the current version of commitlint the body is truncated unexpectedly when there is a pattern like '- Something between dashes -' in the commit message body. The reason for this behavior is that in the commit parser package the commitlint uses (conventional-commit-parser[1]), this pattern '- something -' is a special pattern for any arbitrary filed. For example, if you put '-myNote-' in the commit message body, everything that comes after this field will be saved in an arbitrary field called myNote (Or whatever is written between dashes) and you can use it like other fields (header, body, etc.), but I believe we should disable this functionality because, in the commit messages like the one in the bug report that this commit fixes, the user might put stack trace in the commit message body and this way it will be truncated unexpectedly. Fixes conventional-changelog#3428 [1] https://github.com/conventional-changelog/conventional-changelog/blob/master/packages/conventional-commits-parser/README.md
tehraninasab
added a commit
to tehraninasab/commitlint
that referenced
this issue
Jan 3, 2023
In the current version of commitlint the body is truncated unexpectedly when there is a pattern like '- Something between dashes -' in the commit message body. The reason for this behavior is that in the commit parser package the commitlint uses (conventional-commit-parser[1]), this pattern '- something -' is a special pattern for any arbitrary filed. For example, if you put '-myNote-' in the commit message body, everything that comes after this field will be saved in an arbitrary field called myNote (Or whatever is written between dashes) and you can use it like other fields (header, body, etc.), but I believe we should disable this functionality because, in the commit messages like the one in the bug report that this commit fixes, the user might put stack trace in the commit message body and this way it will be truncated unexpectedly. Fixes conventional-changelog#3428 [1] https://github.com/conventional-changelog/conventional-changelog/blob/master/packages/conventional-commits-parser/README.md
tehraninasab
added a commit
to tehraninasab/commitlint
that referenced
this issue
Jan 3, 2023
In the current version of commitlint the body is truncated unexpectedly when there is a pattern like '- Something between dashes -' in the commit message body. The reason for this behavior is that in the commit parser package the commitlint uses (conventional-commit-parser[1]), this pattern '- something -' is a special pattern for any arbitrary filed. For example, if you put '-myNote-' in the commit message body, everything that comes after this field will be saved in an arbitrary field called myNote (Or whatever is written between dashes) and you can use it like other fields (header, body, etc.), but I believe we should disable this functionality because, in the commit messages like the one in the bug report that this commit fixes, the user might put stack trace in the commit message body and this way it will be truncated unexpectedly. Fixes conventional-changelog#3428 [1] https://github.com/conventional-changelog/conventional-changelog/blob/master/packages/conventional-commits-parser/README.md
tehraninasab
added a commit
to tehraninasab/commitlint
that referenced
this issue
Jan 3, 2023
In the current version of commitlint the body is truncated unexpectedly when there is a pattern like '- Something between dashes -' in the commit message body. The reason for this behavior is that in the commit parser package the commitlint uses (conventional-commit-parser[1]), this pattern '- something -' is a special pattern for any arbitrary filed. For example, if you put '-myNote-' in the commit message body, everything that comes after this field will be saved in an arbitrary field called myNote (Or whatever is written between dashes) and you can use it like other fields (header, body, etc.), but I believe we should disable this functionality because, in the commit messages like the one in the bug report that this commit fixes, the user might put stack trace in the commit message body and this way it will be truncated unexpectedly. Fixes conventional-changelog#3428 [1] https://github.com/conventional-changelog/conventional-changelog/blob/master/packages/conventional-commits-parser/README.md
tehraninasab
added a commit
to tehraninasab/commitlint
that referenced
this issue
Jan 3, 2023
In the current version of commitlint the body is truncated unexpectedly when there is a pattern like '- Something between dashes -' in the commit message body. The reason for this behavior is that in the commit parser package the commitlint uses (conventional-commit-parser[1]), this pattern '- something -' is a special pattern for any arbitrary filed. For example, if you put '-myNote-' in the commit message body, everything that comes after this field will be saved in an arbitrary field called myNote (Or whatever is written between dashes) and you can use it like other fields (header, body, etc.), but I believe we should disable this functionality because, in the commit messages like the one in the bug report that this commit fixes, the user might put stack trace in the commit message body and this way it will be truncated unexpectedly. Fixes conventional-changelog#3428 [1] https://github.com/conventional-changelog/conventional-changelog/blob/master/packages/conventional-commits-parser/README.md
tehraninasab
added a commit
to tehraninasab/commitlint
that referenced
this issue
Jan 3, 2023
In the current version of commitlint the body is truncated unexpectedly when there is a pattern like '- Something between dashes -' in the commit message body. The reason for this behavior is that in the commit parser package the commitlint uses (conventional-commit-parser[1]), this pattern '- something -' is a special pattern for any arbitrary filed. For example, if you put '-myNote-' in the commit message body, everything that comes after this field will be saved in an arbitrary field called myNote (Or whatever is written between dashes) and you can use it like other fields (header, body, etc.), but I believe we should disable this functionality because, in the commit messages like the one in the bug report that this commit fixes, the user might put stack trace in the commit message body and this way it will be truncated unexpectedly. Fixes conventional-changelog#3428 [1] https://github.com/conventional-changelog/conventional-changelog/blob/master/packages/conventional-commits-parser/README.md
escapedcat
pushed a commit
that referenced
this issue
Jan 4, 2023
* test(parser): add failing test * fix: stop truncating the body in presence of dashes In the current version of commitlint the body is truncated unexpectedly when there is a pattern like '- Something between dashes -' in the commit message body. The reason for this behavior is that in the commit parser package the commitlint uses (conventional-commit-parser[1]), this pattern '- something -' is a special pattern for any arbitrary filed. For example, if you put '-myNote-' in the commit message body, everything that comes after this field will be saved in an arbitrary field called myNote (Or whatever is written between dashes) and you can use it like other fields (header, body, etc.), but I believe we should disable this functionality because, in the commit messages like the one in the bug report that this commit fixes, the user might put stack trace in the commit message body and this way it will be truncated unexpectedly. Fixes #3428 [1] https://github.com/conventional-changelog/conventional-changelog/blob/master/packages/conventional-commits-parser/README.md
tehraninasab
added a commit
to tehraninasab/conventions
that referenced
this issue
Jan 31, 2023
The workaround is not needed anymore because we're now using a recent-enough version of commitlint that includes the fix for the bug [1]. [1] conventional-changelog/commitlint#3428
tehraninasab
added a commit
to tehraninasab/conventions
that referenced
this issue
Jan 31, 2023
The workaround is not needed anymore because we're now using a recent-enough version of commitlint that includes the fix for the bug [1]. [1] conventional-changelog/commitlint#3428
tehraninasab
added a commit
to tehraninasab/conventions
that referenced
this issue
Feb 3, 2023
The workaround is not needed anymore because we're now using a recent-enough version of commitlint that includes the fix for the bug [1]. [1] conventional-changelog/commitlint#3428
tehraninasab
added a commit
to tehraninasab/conventions
that referenced
this issue
Feb 4, 2023
The workaround is not needed anymore because we're now using a recent-enough version of commitlint that includes the fix for the bug [1]. [1] conventional-changelog/commitlint#3428
tehraninasab
added a commit
to tehraninasab/conventions
that referenced
this issue
Feb 7, 2023
The workaround is not needed anymore because we're now using a recent-enough version of commitlint that includes the fix for the bug [1]. [1] conventional-changelog/commitlint#3428
tehraninasab
added a commit
to tehraninasab/conventions
that referenced
this issue
Feb 7, 2023
The workaround is not needed anymore because we're now using a recent-enough version of commitlint that includes the fix for the bug [1]. [1] conventional-changelog/commitlint#3428
tehraninasab
added a commit
to tehraninasab/conventions
that referenced
this issue
Feb 9, 2023
The workaround is not needed anymore because we're now using a recent-enough version of commitlint that includes the fix for the bug [1]. [1] conventional-changelog/commitlint#3428
tehraninasab
added a commit
to tehraninasab/conventions
that referenced
this issue
Feb 9, 2023
The workaround is not needed anymore because we're now using a recent-enough version of commitlint that includes the fix for the bug [1]. [1] conventional-changelog/commitlint#3428
tehraninasab
added a commit
to tehraninasab/conventions
that referenced
this issue
Feb 9, 2023
The workaround is not needed anymore because we're now using a recent-enough version of commitlint that includes the fix for the bug [1]. [1] conventional-changelog/commitlint#3428
tehraninasab
added a commit
to tehraninasab/conventions
that referenced
this issue
Feb 9, 2023
The workaround is not needed anymore because we're now using a recent-enough version of commitlint that includes the fix for the bug [1]. [1] conventional-changelog/commitlint#3428
tehraninasab
added a commit
to tehraninasab/conventions
that referenced
this issue
Feb 9, 2023
The workaround is not needed anymore because we're now using a recent-enough version of commitlint that includes the fix for the bug [1]. [1] conventional-changelog/commitlint#3428
tehraninasab
added a commit
to tehraninasab/conventions
that referenced
this issue
Feb 9, 2023
The workaround is not needed anymore because we're now using a recent-enough version of commitlint that includes the fix for the bug [1]. [1] conventional-changelog/commitlint#3428
tehraninasab
added a commit
to tehraninasab/conventions
that referenced
this issue
Feb 9, 2023
The workaround is not needed anymore because we're now using a recent-enough version of commitlint that includes the fix for the bug [1]. [1] conventional-changelog/commitlint#3428
tehraninasab
added a commit
to tehraninasab/conventions
that referenced
this issue
Feb 13, 2023
The workaround is not needed anymore because we're now using a recent-enough version of commitlint that includes the fix for the bug [1]. [1] conventional-changelog/commitlint#3428
tehraninasab
added a commit
to tehraninasab/conventions
that referenced
this issue
Feb 13, 2023
The workaround is not needed anymore because we're now using a recent-enough version of commitlint that includes the fix for the bug [1]. [1] conventional-changelog/commitlint#3428
tehraninasab
added a commit
to tehraninasab/conventions
that referenced
this issue
Feb 14, 2023
The workaround is not needed anymore because we're now using a recent-enough version of commitlint that includes the fix for the bug [1]. [1] conventional-changelog/commitlint#3428
tehraninasab
added a commit
to tehraninasab/conventions
that referenced
this issue
Feb 14, 2023
The workaround is not needed anymore because we're now using a recent-enough version of commitlint that includes the fix for the bug [1]. [1] conventional-changelog/commitlint#3428
tehraninasab
added a commit
to tehraninasab/conventions
that referenced
this issue
Feb 14, 2023
The workaround is not needed anymore because we're now using a recent-enough version of commitlint that includes the fix for the bug [1]. [1] conventional-changelog/commitlint#3428
tehraninasab
added a commit
to tehraninasab/conventions
that referenced
this issue
Feb 14, 2023
The workaround is not needed anymore because we're now using a recent-enough version of commitlint that includes the fix for the bug [1]. [1] conventional-changelog/commitlint#3428
tehraninasab
added a commit
to tehraninasab/conventions
that referenced
this issue
Feb 14, 2023
The workaround is not needed anymore because we're now using a recent-enough version of commitlint that includes the fix for the bug [1]. [1] conventional-changelog/commitlint#3428
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected Behavior
The body shouldn't be truncated.
Current Behavior
The body is truncated unexpectedly when there is a pattern like '- Something between dashes -' in the commit message body:
The commit message:
Affected packages
Possible Solution
No response
Steps to Reproduce
Developed a local plugin like documented here:
https://github.com/conventional-changelog/commitlint/blob/master/docs/reference-plugins.md#local-plugins
So the config file starts like this:
Run the plugin against the commit message mentioned in the Current Behaviour
The body in 'body-soft-max-line-length' is truncated as mentioned in the Current Behaviour section.
Context
No response
commitlint --version
17.3.0
git --version
2.34.1
node --version
v18.12.1
The text was updated successfully, but these errors were encountered: