-
Notifications
You must be signed in to change notification settings - Fork 914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Heavy typescript
dependency since v13
#3218
Comments
Out of the blue it could be related to adding https://github.com/Codex-/cosmiconfig-typescript-loader so people can use TS for their configs. Happy for any suggestions how to improve this. |
In such case users should be responsible for ensuring TS in their own capacity. e.g. it's exactly what we're doing in Serverless Framework, we allow users to write configuration in TS, but that doesn't make a TS tooling a mandatory dependency of the package (that'll bump our package size through the roof). Users on their own need to ensure then that |
Closing this in favour of #3221 |
…onfiguration **@commitlint/cli** added support for TypeScript-based configurations via `ts-node`, and that has caused a good deal of grief: conventional-changelog/commitlint#3420 conventional-changelog/commitlint#3351 conventional-changelog/commitlint#3218 conventional-changelog/commitlint#3256 hoverinc/web-react#1792 Both because it's a heavy-ass dependency and because it requires configuration to work properly. It seems like project-local configuration can affect it's invocation of ts-node, which happens even JavaScript configuration files now?... lame. Anyways, this ensures we avoid any type-checking that happens in it's ts-node invocation until we get a better solution upstream (or contribute one). Ideally, installing ts-node would be opt-in etc.
@escapedcat this is still an issue; I don't use
|
Even without |
I've just upgraded
@commitlint/cli
from v12 to v17, and found out that the package started to requiretypescript
and related modules, why exactly it's the case for a such simple thing as commit message linter?Note, that those extra packages are quite heavy and now total size of
@commitlint/cli
doesn't seem to be really justifiedThe text was updated successfully, but these errors were encountered: