Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make flux-operator manager container imagePullPolicy to be configurable #50

Merged
merged 2 commits into from
Feb 25, 2025

Conversation

shuozhao-anz
Copy link
Contributor

Make flux-operator manager container imagePullPolicy to be configurable.

The reason is that our organization has Gatekeeper enforced in the clusters, one of the violation is that:
Container 'manager' must either use an image digest or set 'imagePullPolicy: Always'

Currently, the imagePullPolicy for flux-operator manager container is hard coded to be 'IfNotPresent'

@stefanprodan
Copy link
Member

@shuozhao-anz can you please run make manifests and force push, also please add validation with @schema enum

@shuozhao-anz
Copy link
Contributor Author

Hi @stefanprodan, I tried make manifests from my local and got the error:

Error: unknown command "Projects/tmp/charts/charts/flux-instance/values.yaml" for "schema"

my version of helm schema --help output like this: which is same as genjsonschema-cli --help
Screenshot 2025-02-25 at 10 15 56 am

It seems like it doesn't recognize the flag -input, -output, -draft etc.

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

PS. I'll fix the schema before the next release

@stefanprodan stefanprodan merged commit 4664fda into controlplaneio-fluxcd:main Feb 25, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants