Instead of option_as_alt introduce command_as_alt and fix behaviour #1718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think I got inspired by some other app to map "option as alt". 🤔 |
| @@ -445,7 +445,7 @@ struct TerminalProfile | |||
| ConfigEntry<HyperlinkDecorationConfig, documentation::HyperlinkDecoration> hyperlinkDecoration {}; | |||
|
|
|||
| ConfigEntry<std::string, documentation::WMClass> wmClass { CONTOUR_APP_ID }; | |||
| ConfigEntry<bool, documentation::OptionKeyAsAlt> optionKeyAsAlt { false }; | |||
| ConfigEntry<bool, documentation::CommandKeyAsAlt> commandKeyAsAlt { true }; | |||
There was a problem hiding this comment.
do we really want to default to true here?
There was a problem hiding this comment.
I think that this is better for the default since user do not need to tweak config to use Alt+something key mappings on mac
| @@ -246,7 +246,7 @@ profiles: | |||
| # This value is ignored on other platforms. | |||
| # | |||
| # Default: false | |||
| option_as_alt: false | |||
| command_as_alt: false | |||
There was a problem hiding this comment.
above it says default is true, here false 🤔
| @@ -398,6 +398,7 @@ void YAMLConfigReader::loadFromEntry(YAML::Node const& node, std::string const& | |||
| loadFromEntry(child, "insert_after_yank", where.insertAfterYank); | |||
| loadFromEntry(child, "bell", where.bell); | |||
| loadFromEntry(child, "wm_class", where.wmClass); | |||
| loadFromEntry(child, "command_as_alt", where.commandKeyAsAlt); | |||
There was a problem hiding this comment.
option_as_alt was not removed?
There was a problem hiding this comment.
ah, looks like it was not there since config refactor. oops :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on my system macOS shows Sigma symbol when I press Option+W for example, same happening to other keybindings, maybe it is better to use command instead of option as an alt alternative on the macos then? @christianparpart
Also, PR fixes option_as_alt behaviour since we need to check for APPLE macro and send press event to trigger user key_mappings action
Closes #1607.