Allow naming of the tabs #1705
Allow naming of the tabs #1705
Conversation
github-actions
bot
added
VT: Backend
src/vtbackend/StatusLineBuilder.cpp
Outdated
| @@ -156,6 +157,7 @@ std::optional<StatusLineDefinitions::Item> makeStatusLineItem( | |||
| styles, | |||
| activeColor, | |||
| activeBackground, | |||
| std::nullopt, | |||
There was a problem hiding this comment.
can we use designated initializers here?
There was a problem hiding this comment.
I will add a comment, that this is separator, because this class has an inheritance and we can not use designated initialization here :(
Yaraslaut
force-pushed
the
feature/tabs_naming
branch
3 times, most recently
from
6caa4ba to
e0b350e
Compare
Yaraslaut
force-pushed
the
feature/tabs_naming
branch
from
e0b350e to
9469f71
Compare
| "{SearchPrompt:Left= │ }" | ||
| "{TraceMode:Bold,Color=#FFFF00,Left= │ }" | ||
| "{ProtectedMode:Bold,Left= │ }" }; | ||
| std::string middle { "{Title:Left= « ,Right= » }" }; | ||
| std::string middle { "{Tabs: ActiveColor=#FFFF00}" }; |
There was a problem hiding this comment.
Let's figure out what this space is used for here :)
| std::string const& Terminal::windowTitle() const noexcept | ||
| { | ||
| return _windowTitle; | ||
| } | ||
|
|
||
| void Terminal::setTabName() | ||
| { | ||
| inputHandler().setTabName([&](std::string name) { _tabName = name; }); |
There was a problem hiding this comment.
| inputHandler().setTabName([&](std::string name) { _tabName = name; }); | |
| inputHandler().setTabName([&](std::string name) { _tabName = std::move(name); }); |
| @@ -54,7 +53,10 @@ class TerminalSessionManager: public QAbstractListModel | |||
| display::TerminalDisplay* display = nullptr; | |||
| TerminalSession* getSession() { return _sessions[0]; } | |||
|
|
|||
| void Update() { updateStatusLine(); } | |||
There was a problem hiding this comment.
| void Update() { updateStatusLine(); } | |
| void update() { updateStatusLine(); } |
| @@ -1562,11 +1562,26 @@ void Terminal::setWindowTitle(string_view title) | |||
| _eventListener.setWindowTitle(title); | |||
| } | |||
|
|
|||
| void Terminal::setTabName(string_view title) | |||
There was a problem hiding this comment.
not used. either remove, or at least accept title as std::string and then move ;it into _tabName :)
| void setGuiTabInfoForStatusLine(TabsInfo&& info) { _guiTabInfoForStatusLine = std::move(info); } | ||
|
|
||
| TabsNamingMode getTabsNamingMode() const noexcept { return _settings.tabNamingMode; } | ||
| void setTabName(); |
There was a problem hiding this comment.
can we maybe figure out a better name of it? Because setTabName sounds like you're setting a tab name, and you're usually also passing the name.
| @@ -444,25 +457,26 @@ void ViInputHandler::startSearchExternally() | |||
|
|
|||
| Handled ViInputHandler::handleSearchEditor(char32_t ch, Modifiers modifiers) | |||
| { | |||
| assert(_searchEditMode != SearchEditMode::Disabled); | |||
| assert(_searchEditMode != PromptMode::Disabled); | |||
There was a problem hiding this comment.
let's see if we can find a way to not duplicate the input handling by "dependency injection", implementing the custom behavior through some common interface (search vs tab naming vs future-feature)
| void setSearchModeSwitch(bool enabled); | ||
| void clearSearch(); | ||
|
|
||
| private: | ||
| std::optional<std::function<void(std::string)>> _setTabNameCallback { std::nullopt }; |
There was a problem hiding this comment.
let's move member variable declarations together (below)
Refs #1690
PR Adds naming to the tabs, and adds another option to the Tabs status line config, separator