Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix to build with boxed-cpp #1301

Merged
merged 4 commits into from
Oct 24, 2023
Merged

fix to build with boxed-cpp #1301

merged 4 commits into from
Oct 24, 2023

Conversation

topazus
Copy link
Contributor

@topazus topazus commented Oct 23, 2023

Description

The PR is related to contour-terminal/boxed-cpp#9

How Has This Been Tested?

  • Please describe how you tested your changes.
  • see how your change affects other areas of the code, etc.

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

If you're unsure about any of these, don't hesitate to ask. We're here to help!

  • I have read the CONTRIBUTING document in my spoken language, and understand the terms
  • I have updated (or added) the documentation accordingly.
  • I have added tests to cover my changes.
  • I have gone through all the steps, and have thoroughly read the instructions

@github-actions github-actions bot added the CMake label Oct 23, 2023
@topazus
Copy link
Contributor Author

topazus commented Oct 23, 2023

The error appeared in Ubuntu 20.04 was seemingly caused by the reason that GCC 9 does not support C++ 20 concepts.

@Yaraslaut
Copy link
Member

The error appeared in Ubuntu 20.04 was seemingly caused by the reason that GCC 9 does not support C++ 20 concepts.

I see that g++10 is there https://packages.ubuntu.com/focal/g++-10
We can update GitHub action to compile with gcc-10

@Yaraslaut
Copy link
Member

@topazus Can you update github action then please? If you are bussy i can do it as well

@topazus
Copy link
Contributor Author

topazus commented Oct 23, 2023

I do not have a compuer at hand right now. Grateful if you do this. @Yaraslaut

@github-actions github-actions bot added the CI GitHub Actions & CI label Oct 23, 2023
@Yaraslaut
Copy link
Member

@topazus I updated PR, builds are fine now, if you fill that PR is no longer in draft, make it then ready for review to proceeed with merging

@topazus topazus marked this pull request as ready for review October 23, 2023 10:31
Copy link
Member

@christianparpart christianparpart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just have a minor improvement suggestion. Otherwise, many thanks!

.github/workflows/build.yml Outdated Show resolved Hide resolved
Co-authored-by: Christian Parpart <[email protected]>
@Yaraslaut Yaraslaut enabled auto-merge (squash) October 23, 2023 15:02
@Yaraslaut Yaraslaut merged commit 9b8c5a6 into contour-terminal:master Oct 24, 2023
55 checks passed
@topazus topazus deleted the fix branch December 26, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI GitHub Actions & CI CMake
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants