-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix to build with boxed-cpp #1301
Conversation
The error appeared in Ubuntu 20.04 was seemingly caused by the reason that GCC 9 does not support C++ 20 concepts. |
I see that g++10 is there https://packages.ubuntu.com/focal/g++-10 |
@topazus Can you update github action then please? If you are bussy i can do it as well |
I do not have a compuer at hand right now. Grateful if you do this. @Yaraslaut |
@topazus I updated PR, builds are fine now, if you fill that PR is no longer in draft, make it then ready for review to proceeed with merging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just have a minor improvement suggestion. Otherwise, many thanks!
Co-authored-by: Christian Parpart <[email protected]>
Description
The PR is related to contour-terminal/boxed-cpp#9
How Has This Been Tested?
Checklist:
Go over all the following points, and put an
x
in all the boxes that apply.If you're unsure about any of these, don't hesitate to ask. We're here to help!
CONTRIBUTING
document in my spoken language, and understand the terms