Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor configuration loading #1300

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Refactor configuration loading #1300

merged 1 commit into from
Feb 16, 2024

Conversation

Yaraslaut
Copy link
Member

@Yaraslaut Yaraslaut commented Oct 22, 2023 •
edited
Loading

Closes #1292
Refs #1282

@github-actions github-actions bot added frontend Contour Terminal Emulator (GUI frontend) VT: Backend Virtual Terminal Backend (libterminal API) labels Oct 22, 2023
christianparpart
christianparpart reviewed Oct 30, 2023
View reviewed changes
Copy link
Member

@christianparpart christianparpart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first bits of thoughts

src/contour/Config.h Outdated Show resolved Hide resolved
src/contour/Config.h Outdated Show resolved Hide resolved
src/contour/Config.h Outdated Show resolved Hide resolved
src/contour/Config.h Outdated Show resolved Hide resolved
src/contour/Config.h Outdated Show resolved Hide resolved
src/contour/Config.h Outdated Show resolved Hide resolved
src/contour/Config.h Outdated Show resolved Hide resolved
src/contour/Config.h Outdated Show resolved Hide resolved
@github-actions github-actions bot added the fonts font rasterization and text shaping API and platform implementations label Oct 30, 2023
@Yaraslaut
Copy link
Member Author

refs #1282

@Yaraslaut Yaraslaut force-pushed the improvement/config_refactor branch 2 times, most recently from 60cb924 to 07fc739 Compare November 5, 2023 17:46
christianparpart
christianparpart reviewed Nov 21, 2023
View reviewed changes
Copy link
Member

@christianparpart christianparpart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some more bits of looking through :)

src/contour/Config.h Outdated Show resolved Hide resolved
src/contour/Config.h Outdated Show resolved Hide resolved
src/contour/Config.h Outdated Show resolved Hide resolved
src/contour/Config.h Outdated Show resolved Hide resolved
src/contour/Config.h Outdated Show resolved Hide resolved
src/contour/Config.h Outdated Show resolved Hide resolved
src/contour/Config.h Outdated Show resolved Hide resolved
src/contour/Config.h Outdated Show resolved Hide resolved
src/contour/Config.h Outdated Show resolved Hide resolved
@Yaraslaut Yaraslaut force-pushed the improvement/config_refactor branch 2 times, most recently from c649651 to b4dac41 Compare November 25, 2023 20:47
@Yaraslaut Yaraslaut force-pushed the improvement/config_refactor branch from 513f2bd to 127a515 Compare December 6, 2023 19:52
@christianparpart christianparpart mentioned this pull request Dec 27, 2023
Closed
@Yaraslaut Yaraslaut force-pushed the improvement/config_refactor branch 3 times, most recently from c031922 to 46153f1 Compare January 21, 2024 18:28
@Yaraslaut Yaraslaut changed the title [WIP] refactor configuration loading refactor configuration loading Feb 4, 2024
@Yaraslaut Yaraslaut changed the title refactor configuration loading Refactor configuration loading Feb 4, 2024
@Yaraslaut Yaraslaut marked this pull request as ready for review February 4, 2024 15:25
@Yaraslaut Yaraslaut closed this Feb 6, 2024
@Yaraslaut Yaraslaut force-pushed the improvement/config_refactor branch from 9bd623c to 7adc8c7 Compare February 6, 2024 21:31
@Yaraslaut Yaraslaut reopened this Feb 6, 2024
@Yaraslaut Yaraslaut force-pushed the improvement/config_refactor branch 9 times, most recently from 2153a75 to 1869695 Compare February 13, 2024 17:46
@Yaraslaut Yaraslaut force-pushed the improvement/config_refactor branch 6 times, most recently from 5e88bcd to 6d2a1db Compare February 14, 2024 07:49
@github-actions github-actions bot added the CI GitHub Actions & CI label Feb 14, 2024
@Yaraslaut Yaraslaut force-pushed the improvement/config_refactor branch 6 times, most recently from e91e736 to 89776e9 Compare February 14, 2024 14:03
@Yaraslaut Yaraslaut force-pushed the improvement/config_refactor branch from 89776e9 to b328cdb Compare February 16, 2024 07:32
christianparpart
christianparpart approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@christianparpart christianparpart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am really curious now. Many thanks, man :)

@christianparpart christianparpart merged commit ee4d25c into master Feb 16, 2024
57 checks passed
@christianparpart christianparpart deleted the improvement/config_refactor branch February 16, 2024 20:38
@christianparpart christianparpart mentioned this pull request Feb 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christianparpart christianparpart christianparpart approved these changes

Assignees
No one assigned
Labels
CI GitHub Actions & CI fonts font rasterization and text shaping API and platform implementations frontend Contour Terminal Emulator (GUI frontend) VT: Backend Virtual Terminal Backend (libterminal API)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

in case of bad font config, default to something existing
2 participants
@Yaraslaut @christianparpart