Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make runtime (un-)initialization implicit in most cases #72

Merged
merged 1 commit into from
Jun 10, 2019

Conversation

Boddlnagg
Copy link
Collaborator

... and allow STA initialization (fixes #62).

@rbtying @BenJKuhn Can you have a look at this?

@Boddlnagg Boddlnagg added this to the 0.6 milestone May 18, 2019
Copy link
Contributor

@rbtying rbtying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks generally reasonable to me from my understanding of COM/WinRT. Would we want to retain the RuntimeContext struct and mark it deprecated, for migration reasons?

@Boddlnagg
Copy link
Collaborator Author

Generally in the Rust crate ecosystem there are no strong stability guarantees for pre-1.0 versions. At least that is my impression. The versions are not semver-compatible anyway, so I think a hard removal is not a problem. But you might be able to convince me otherwise ;-)

@Boddlnagg Boddlnagg merged commit 0bbf8ec into contextfree:master Jun 10, 2019
@Boddlnagg Boddlnagg deleted the implicit-init branch June 10, 2019 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RO_INIT_MULTITHREADED doesn’t work for everything
2 participants