fix: pin axios to 1.6.x to prevent request params from being duplicated on retries #2253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgoudy91
approved these changes
Jun 12, 2024
t-col
force-pushed
the
fix/duplicated-request-params
branch
from
2cc6986 to
5a8c797
Compare
|
🎉 This PR is included in version 10.11.11 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Heads up that axios was updated again: #2255 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
addresses #2246
The bug in our SDK can be traced to the upgrade of
axiosfrom 1.6.8 to 1.7.x (here). I'm not yet certain if this new version ofaxioshas a bug, of if a fix there exposed a bug in our implementation of it. For now we'll pin ouraxiosdependency to the last known compatible minor version, 1.6.x