fix(builder): filter self-referencing validations #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @HannesT117 thanks for the PR! while i was looking at your solution, I was wondering if it's possible to find a single point in code where we could strip out self referencing imports. So i came to this solution here: #23 What do you think? |
|
Cool, I was quite sure that I had missed something - looks good :) Closing this PR therefore. |
|
@HannesT117 I merged mine - happy referencing :) |
|
@marcolink perfect, thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #19
Not sure where to best filter the validations, this was my initial approach to fix the issue.