fix(textarea,toolbar): set text caret after emoji #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I updated library. but still not fixed. |
@tuannguyenminh2086 @himynameistimli The latest version bump didn't push a new I didn't push |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an emoji is inserted via the toolbar or textarea controls, the text caret (not visible due to #49, but I have a PR coming to fix that as well) is positioned before the inserted emoji. Subsequent emoji insertions or keyboard input occur before the inserted emoji as opposed to after.
Changes proposed in this pull request:
Set text caret position to just after inserted emoji using the
setTimeouttechnique as is done with completions inmodule-emoji.jsFixes: bug described in this PR. No "official" issue is opened for this but I can make one if desired.