feat: allow hostname override for notifiers #994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it currently stands all notifiers utilise `os.Hostname` to populate their titles/subjects. When utilising Docker with a bridged network if you set the hostname for a container to an external DNS hostname Docker's internal DNS resolver will override said hostname for all containers within the bridged network. This change allows a user to specify what hostname should be represented in the email notifications without having to change the `os.Hostname`.
Codecov Report
@@ Coverage Diff @@
## main #994 +/- ##
==========================================
+ Coverage 56.15% 56.22% +0.06%
==========================================
Files 25 25
Lines 1453 1462 +9
==========================================
+ Hits 816 822 +6
- Misses 567 568 +1
- Partials 70 72 +2
Continue to review full report at Codecov.
|
piksel
requested changes
Jun 18, 2021
There was a problem hiding this comment.
The title isn't tied to email anymore (hence why it's in pkg/notifications/notifier.go). It should not be too difficult to set the notification hostname either to the flag value, or if empty, os.Hostname.
There are more places to change than the one below obviously though.
nightah
changed the title
piksel
requested changes
Jun 18, 2021
piksel
approved these changes
Jun 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it currently stands all notifiers utilise
os.Hostnameto populate their titles/subjects.When utilising Docker with a bridged network if you set the hostname for a container to an external DNS hostname Docker's internal DNS resolver will override said hostname for all containers within the bridged network.
This change allows a user to specify what hostname should be represented in the notifications without having to change the
os.Hostname.