Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove stray paragraph in notifications #949

Merged
merged 2 commits into from
May 3, 2021
Merged

Conversation

piksel
Copy link
Member

@piksel piksel commented May 2, 2021

the paragraph from the slack documentation were originally it's own section in the readme:

watchtower/README.md

Lines 406 to 409 in 985a922

## Updating Watchtower
If watchtower is monitoring the same Docker daemon under which the watchtower container itself is running (i.e. if you volume-mounted _/var/run/docker.sock_ into the watchtower container) then it has the ability to update itself. If a new version of the _containrrr/watchtower_ image is pushed to the Docker Hub, your watchtower will pull down the new image and restart itself automatically.

I added it back as well, since it could still be a useful section to have and it's definitely something that's missing from the docs right now. Could do with some more explaining and tips (pinning older version?)

fixes #946

@codecov
Copy link

codecov bot commented May 2, 2021

Codecov Report

Merging #949 (cbc7f96) into main (6b155a1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #949   +/-   ##
=======================================
  Coverage   54.47%   54.47%           
=======================================
  Files          25       25           
  Lines        1452     1452           
=======================================
  Hits          791      791           
  Misses        594      594           
  Partials       67       67           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91bbe74...cbc7f96. Read the comment docs.

@simskij simskij merged commit 61b715a into main May 3, 2021
@simskij simskij deleted the docs/rm-stray-para branch May 3, 2021 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation contains paragraph in unexpected location
2 participants