Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix metrics api test stability #930

Merged
merged 4 commits into from
May 25, 2021
Merged

test: fix metrics api test stability #930

merged 4 commits into from
May 25, 2021

Conversation

piksel
Copy link
Member

@piksel piksel commented Apr 24, 2021

Should permanently solve the intermittent test failures.

@codecov
Copy link

codecov bot commented Apr 24, 2021

Codecov Report

Merging #930 (1f526d5) into main (b4cf17d) will increase coverage by 14.33%.
The diff coverage is 100.00%.

❗ Current head 1f526d5 differs from pull request most recent head c4a338f. Consider uploading reports for the commit c4a338f to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##             main     #930       +/-   ##
===========================================
+ Coverage   40.14%   54.47%   +14.33%     
===========================================
  Files          25       25               
  Lines        1415     1452       +37     
===========================================
+ Hits          568      791      +223     
+ Misses        785      594      -191     
- Partials       62       67        +5     
Impacted Files Coverage Δ
pkg/notifications/shoutrrr.go 73.43% <100.00%> (+0.42%) ⬆️
internal/actions/update.go 50.47% <0.00%> (-0.55%) ⬇️
pkg/registry/digest/digest.go 0.00% <0.00%> (ø)
pkg/notifications/email.go 90.90% <0.00%> (+4.54%) ⬆️
pkg/container/client.go 14.59% <0.00%> (+14.59%) ⬆️
internal/flags/flags.go 88.47% <0.00%> (+36.89%) ⬆️
pkg/container/container.go 47.31% <0.00%> (+47.31%) ⬆️
pkg/container/metadata.go 63.63% <0.00%> (+63.63%) ⬆️
pkg/container/util.go 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d38e52b...c4a338f. Read the comment docs.

@simskij simskij marked this pull request as draft April 24, 2021 19:12
@piksel piksel force-pushed the fix/http-api-tests branch from 1f526d5 to c4a338f Compare May 21, 2021 13:20
@piksel piksel marked this pull request as ready for review May 21, 2021 13:23
@piksel piksel requested a review from simskij May 21, 2021 13:24
@simskij
Copy link
Member

simskij commented May 24, 2021

I know we found out that the actual reason for the problems was how we do the calls, nevertheless I think the httptest part of this PR is a welcome change as well as it makes the tests less fragile overall. Good job!

@piksel piksel merged commit dec6f84 into main May 25, 2021
@piksel piksel deleted the fix/http-api-tests branch May 25, 2021 14:42
@piksel piksel changed the title test: use httptest instead of host port binding test: fix metrics api test stability May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants