Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: suggest mounting localtime, not timezone #877

Merged
merged 1 commit into from
Apr 18, 2021
Merged

Conversation

piksel
Copy link
Member

@piksel piksel commented Apr 2, 2021

The current docs suggests mounting the hosts /etc/timezone into the watchtower container, but that has no effect.

/etc/localtime is usually a symlink to /usr/share/zoneinfo/<contents of /etc/timezone>, but that symlink has to be created. So whatever is in /etc/timezone does not affect the actual tz database being used in watchtower, and since the image is a base image, no service that updates that symlink ever runs.

Instead, this would change the docs to suggest directly mounting the hosts /etc/localtime file.

Fixes #876

@piksel piksel changed the title docs: suggest mounting localtime, not of timezone docs: suggest mounting localtime, not timezone Apr 2, 2021
@codecov
Copy link

codecov bot commented Apr 2, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@a5ffb65). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #877   +/-   ##
=======================================
  Coverage        ?   43.07%           
=======================================
  Files           ?       24           
  Lines           ?     1379           
  Branches        ?        0           
=======================================
  Hits            ?      594           
  Misses          ?      724           
  Partials        ?       61           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5ffb65...487fe87. Read the comment docs.

@simskij simskij merged commit 62a6d31 into main Apr 18, 2021
@simskij simskij deleted the docs/tz-mount branch April 18, 2021 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

watchtower ignores mounted /etc/timezone file
2 participants