Pre-update lifecycle hook

[yrien30]

Will close #649

[codecov]

Codecov Report

Merging #793 (f8c9e8d) into main (6b155a1) will increase coverage by 0.91%.
The diff coverage is 52.94%.

@@            Coverage Diff             @@
##             main     #793      +/-   ##
==========================================
+ Coverage   54.47%   55.38%   +0.91%     
==========================================
  Files          25       25              
  Lines        1452     1466      +14     
==========================================
+ Hits          791      812      +21     
+ Misses        594      590       -4     
+ Partials       67       64       -3     

Impacted Files	Coverage Δ
pkg/container/client.go	14.46% <0.00%> (-0.13%)	⬇️
pkg/container/container.go	46.80% <0.00%> (-0.51%)	⬇️
internal/actions/update.go	63.79% <81.81%> (+13.31%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91bbe74...f8c9e8d. Read the comment docs.

[kevinlul]

How can I help out? 👀 Just testing?

[yrien30]

How can I help out? 👀 Just testing?

Great if you could test it and maybe come whit suggestion on improving the documentation. I'm also not sure if there should be a own flag for skipping the lifecycle hooks when the container is stoped or restarting.

[yrien30]

I have uploaded it to ghcr.io. So If anyone would test it then you will find it here Its build for arm64.

[yrien30]

I have now tested that this works.

Exit code 1:

Exit code 75:

Container that needs update and is not running. Previously it would not get updated because the preupdate script can only run when the container is running..

Exit code 0:

[yrien30]

Making this a draft again since I found out that the container is not created after it had been deleted. I need figure out why..

[yrien30]

Tested that the container gets started again after latest fix:

[simskij]

Awesome! Thanks for your contribution! I can't review it right now, but will get back to it as soon as possible.

[piksel]

This does look good in general, but there really ought to be tests for the functionality.

Also, some run go fmt to fix things like spaces between arguments.

[yrien30]

This does look good in general, but there really ought to be tests for the functionality.

Also, some run go fmt to fix things like spaces between arguments.

I have added some test and run go fmt. Have also retested everything like I did above manualy after I merged the changes form main.

[yrien30]

Any chance to get an update on whether this could be merged or need more work?

[subdavis]

Without tests, this is a 100 LoC change that several people clearly care about. Thanks to @yrien30 for putting this PR together.

As a show of good faith, I've started sponsoring https://github.com/sponsors/simskij

If this could be reviewed, merged, and released sometime soon, that would be greatly appreciated.

[simskij]

LGTM! Thanks for the contribution! Let's try this in :latest-dev for a bit to make sure it's stable.