Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure all shoutrrr notifications are sent #564

Merged
merged 1 commit into from
Aug 8, 2020

Conversation

CedricFinance
Copy link
Contributor

When watchtower is launched with --run-once, some notifications might not be sent because the app exits before the goroutine has sent all the notifications.

@stale
Copy link

stale bot commented Aug 1, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: Stale label Aug 1, 2020
@regystro
Copy link

regystro commented Aug 2, 2020

Anyone with write access could review this? Thank you.

@stale stale bot removed the Status: Stale label Aug 2, 2020
@piksel piksel self-requested a review August 4, 2020 07:05
@piksel piksel self-assigned this Aug 4, 2020
@simskij simskij merged commit fdecd40 into containrrr:master Aug 8, 2020
@CedricFinance CedricFinance deleted the send-all-notifications branch September 30, 2020 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants