-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add log file support #1813
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations on opening your first pull request! We'll get back to you as soon as possible. In the meantime, please make sure you've updated the documentation to reflect your changes and have added test automation as needed. Thanks! 🙏🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this, and would be happy to merge it after one change: enabling logging to a file should still log to stdout as well.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1813 +/- ##
==========================================
+ Coverage 70.55% 70.56% +0.01%
==========================================
Files 26 26
Lines 2493 2511 +18
==========================================
+ Hits 1759 1772 +13
- Misses 633 638 +5
Partials 101 101 ☔ View full report in Codecov by Sentry. |
add multi writer to support both file output and std out
Sorry for my late replay. I've added a multi writer to support both outputs. |
@simskij Could you please take another look at this PR? |
This PR adds two new flags to enable logging to a file. See #1716