Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(filters): Add a flag/env to explicitly exclude containers by name #1784

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

rdamazio
Copy link
Contributor

@rdamazio rdamazio commented Oct 3, 2023

This adds a way to exclude containers by name, rather than having to set labels.

Resolves #1566

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (9180e95) 68.90% compared to head (b1620f1) 69.23%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1784      +/-   ##
==========================================
+ Coverage   68.90%   69.23%   +0.32%     
==========================================
  Files          26       26              
  Lines        2441     2467      +26     
==========================================
+ Hits         1682     1708      +26     
  Misses        661      661              
  Partials       98       98              
Files Coverage Δ
internal/flags/flags.go 87.02% <100.00%> (+0.15%) ⬆️
pkg/filters/filters.go 90.43% <100.00%> (+1.89%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@piksel piksel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a two small requests...

internal/flags/flags.go Outdated Show resolved Hide resolved
docs/arguments.md Outdated Show resolved Hide resolved
@piksel piksel merged commit 623f4e6 into containrrr:main Oct 4, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-label method for excluding containers
2 participants