fix: remove logging of credentials #1534
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will remove most of the unsafe logging when running with
--trace
. The reason for this change is that it might be used as a vulnerability and there is no good scenario for when they would be useful (since we don't want users including the information in the issues/discussions anyway).If the user/developer needs that information, the corresponding line can just be uncommented and built locally:
The two places where the logging still remains is the notification URL generated by updating legacy notifications to Shoutrrr URLs, and the docker image/container info logged when watchtower does not have enough information to update a container.