fix: update metrics from sessions started via API #1531
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #1530. Metrics are not captured and returned to the metrics handler if called via the HTTP API. This code is already implemented in the existing codebase when a schedule is triggered.
watchtower/cmd/root.go
Lines 322 to 323 in c16ac96
Tests
Ran binary with the following arguments:
--cleanup --schedule "0 0 4 * * *" --http-api-update --http-api-token "******" --http-api-periodic-polls --http-api-metrics
. And curl'd the update endpoint. The below logs were outputted after a successful run.Finally curled the metrics endpoint and saw the correct metric was updated.